Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Relax check for validated data in default factory utils#10909

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
sydney-runkle merged 5 commits intomainfromvalidated-data-fix
Nov 21, 2024

Conversation

sydney-runkle
Copy link
Contributor

@sydney-runklesydney-runkle commentedNov 20, 2024•
edited
Loading

Following up on#10678 (comment)

cc@Viicos, breaking for this case:#10905 (comment)

I think moving inside here makes sense. Though, I understood your original point in the comment 👍

Fixes#10912

@github-actionsgithub-actionsbot added the relnotes-fixUsed for bugfixes. labelNov 20, 2024
@cloudflare-workers-and-pagesCloudflare Workers and Pages
Copy link

cloudflare-workers-and-pagesbot commentedNov 20, 2024•
edited
Loading

Deploying pydantic-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit:dcfe613
Status: ✅  Deploy successful!
Preview URL:https://1e3f818a.pydantic-docs.pages.dev
Branch Preview URL:https://validated-data-fix.pydantic-docs.pages.dev

View logs

@codspeed-hqCodSpeed HQ
Copy link

codspeed-hqbot commentedNov 20, 2024•
edited
Loading

CodSpeed Performance Report

Merging#10909 willnot alter performance

Comparingvalidated-data-fix (dcfe613) withmain (36642e6)

Summary

✅ 46 untouched benchmarks

@github-actionsGitHub Actions
Copy link
Contributor

github-actionsbot commentedNov 20, 2024•
edited
Loading

Coverage report

This PR does not seem to contain any modification to coverable code.

@ViicosViicos mentioned this pull requestNov 21, 2024
36 tasks
@sydney-runklesydney-runkle changed the titleMaybe fix issue with validated data missingRelax check for validated data in default factory utilsNov 21, 2024
Copy link
Member

@ViicosViicos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

We just need to also modify the first overload to be:

@overloaddefget_default(self,*,call_default_factory:Literal[True],validated_data:dict[str,Any]|None= ...)->Any: ...

sydney-runkleand others added4 commitsNovember 21, 2024 09:06
Co-authored-by: Victorien <65306057+Viicos@users.noreply.github.com>
@sydney-runklesydney-runkleenabled auto-merge (squash)November 21, 2024 14:13
@sydney-runklesydney-runkle merged commitb985365 intomainNov 21, 2024
52 checks passed
@sydney-runklesydney-runkle deleted the validated-data-fix branchNovember 21, 2024 14:17
sydney-runkle added a commit that referenced this pull requestNov 22, 2024
Co-authored-by: Victorien <65306057+Viicos@users.noreply.github.com>
brentyi added a commit to brentyi/tyro that referenced this pull requestNov 23, 2024
…oved error messages (#204)* Improve mismatched type for StrEnum* Overhaul subcommand matching* Additional subcommand matching tests* Min 3.11 for StrEnum tests* fix test ignore* Test nits* typeguard compatibility* Add minimum typeguard version* fix typeguard errors* typeguard refactor, more subcommand matching tests* Add 3.13 to CI (fixes#206)* Add pydantic version exclude, waiting for patchRelated:pydantic/pydantic#10912,pydantic/pydantic#10909* Improve type warnings + errors* Generic subcommand example, docs updates* Remove unused* `build` => `pytest`,closes#206* mypy
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@dmontagudmontagudmontagu approved these changes

@ViicosViicosViicos approved these changes

Assignees
No one assigned
Labels
relnotes-fixUsed for bugfixes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2.10:validated_data must be provided ifcall_default_factory is True (affets: SQLModel)
3 participants
@sydney-runkle@dmontagu@Viicos
[8]ページ先頭
©2009-2025 Movatter.jp