Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Use the correct frame when instantiating a parametrizedTypeAdapter#10893

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
Viicos merged 3 commits intomainfrom10892
Nov 21, 2024

Conversation

Viicos
Copy link
Member

@ViicosViicos commentedNov 20, 2024•
edited
Loading

Change Summary

Fixes#10892.

Also update some docstrings to explain better how frame fetching works.

Related issue number

Checklist

  • The pull request title is a good summary of the changes - it will be used in the changelog
  • Unit tests for the changes exist
  • Tests pass on CI
  • Documentation reflects the changes where applicable
  • My PR is ready to review,please add a comment including the phrase "please review" to assign reviewers

@github-actionsgithub-actionsbot added the relnotes-fixUsed for bugfixes. labelNov 20, 2024
@cloudflare-workers-and-pagesCloudflare Workers and Pages
Copy link

cloudflare-workers-and-pagesbot commentedNov 20, 2024•
edited
Loading

Deploying pydantic-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit:88c495f
Status: ✅  Deploy successful!
Preview URL:https://37879cd6.pydantic-docs.pages.dev
Branch Preview URL:https://10892.pydantic-docs.pages.dev

View logs

@codspeed-hqCodSpeed HQ
Copy link

codspeed-hqbot commentedNov 20, 2024•
edited
Loading

CodSpeed Performance Report

Merging#10893 willnot alter performance

Comparing10892 (88c495f) withmain (a5d5c23)

Summary

✅ 46 untouched benchmarks

@github-actionsGitHub Actions
Copy link
Contributor

github-actionsbot commentedNov 20, 2024•
edited
Loading

Coverage report

This PR does not seem to contain any modification to coverable code.

@ViicosViicosforce-pushed the10892 branch 2 times, most recently from4d63e75 to30f43faCompareNovember 20, 2024 13:08
@ViicosViicos marked this pull request as draftNovember 20, 2024 13:51
@ViicosViicos marked this pull request as ready for reviewNovember 20, 2024 16:46
Copy link
Contributor

@sydney-runklesydney-runkle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Looking good, thanks for the docstring reorganization + additions.

Just one follow up question about parent frame fetching :)

@sydney-runklesydney-runkle added the awaiting author revisionawaiting changes from the PR author labelNov 20, 2024
Copy link
Contributor

@sydney-runklesydney-runkle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Nice work, thanks! Let's get this into v2.10.1

@ViicosViicosenabled auto-merge (squash)November 21, 2024 13:52
@ViicosViicos merged commit36642e6 intomainNov 21, 2024
51 checks passed
@ViicosViicos deleted the 10892 branchNovember 21, 2024 13:55
sydney-runkle pushed a commit that referenced this pull requestNov 22, 2024
…#10893)Move all the documentation into the class docstring, rewrite some small parts of it.
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@sydney-runklesydney-runklesydney-runkle approved these changes

Assignees
No one assigned
Labels
awaiting author revisionawaiting changes from the PR authorrelnotes-fixUsed for bugfixes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Wrong parent namespace fetched when using an explicitly parametrizedTypeAdapter
2 participants
@Viicos@sydney-runkle
[8]ページ先頭
©2009-2025 Movatter.jp