Make`signature` a lazy property, do not deepcopy defaults#10818

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Viicos merged 3 commits intomainfrommodel-signature

Nov 13, 2024

Merged

Viicos merged 3 commits intomainfrommodel-signature

Nov 13, 2024

Conversation

Copy link

Member

Also follow stdlib dataclasses for signature parameter defaults. If a default factory is used, the placeholder'<factory>' is used.

The pull request title is a good summary of the changes - it will be used in the changelog
Unit tests for the changes exist
Tests pass on CI
Documentation reflects the changes where applicable
My PR is ready to review,please add a comment including the phrase "please review" to assign reviewers

Make__signature__ a lazy property, do not deepcopy defaults

1ca121a

Also follow stdlib dataclasses for signature parameter defaults.If a default factory is used, the placeholder `'<factory>'` isused.

github-actionsbot added the relnotes-fixUsed for bugfixes. label

Copy link

Latest commit:	`fda5e91`
Status:	✅ Deploy successful!
Preview URL:	https://232345cd.pydantic-docs.pages.dev
Branch Preview URL:	https://model-signature.pydantic-docs.pages.dev

Copy link

_{Comparingmodel-signature (fda5e91) withmain (8bad227)}

⚡ 9 improvements
✅ 35 untouched benchmarks

	Benchmark	`main`	`model-signature`	Change
⚡	`test_model_validators_serializers`	1.1 ms	1.1 ms	+5.76%
⚡	`test_nested_model_schema_generation`	1.4 ms	1.4 ms	+7.13%
⚡	`test_recursive_model_schema_generation`	1.4 ms	1.3 ms	+7.45%
⚡	`test_simple_model_schema_generation`	1,042.9 µs	938.1 µs	+11.17%
⚡	`test_tagged_union_with_callable_discriminator_schema_generation`	2.1 ms	2 ms	+5.22%
⚡	`test_tagged_union_with_str_discriminator_schema_generation`	2 ms	1.9 ms	+5.47%
⚡	`test_deeply_nested_recursive_model_schema_generation`	1.7 ms	1.6 ms	+5.72%
⚡	`test_generic_recursive_model_schema_generation`	1.2 ms	1.1 ms	+9.03%
⚡	`test_simple_recursive_model_schema_generation`	1,003 µs	901.8 µs	+11.23%