Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Improve documentation forvalidate_email#10736

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
Viicos merged 2 commits intopydantic:mainfromk4nar:docs/improve-validate_email-doc
Oct 29, 2024

Conversation

k4nar
Copy link
Contributor

@k4nark4nar commentedOct 29, 2024•
edited
Loading

Change Summary

Improve the documentation ofvalidate_email to indicate what the function returns and which exception it raises.

image

Checklist

  • The pull request title is a good summary of the changes - it will be used in the changelog
  • Tests pass on CI
  • Documentation reflects the changes where applicable
  • My PR is ready to review,please add a comment including the phrase "please review" to assign reviewers

Selected Reviewer:@sydney-runkle

@codspeed-hqCodSpeed HQ
Copy link

codspeed-hqbot commentedOct 29, 2024•
edited
Loading

CodSpeed Performance Report

Merging#10736 willnot alter performance

Comparingk4nar:docs/improve-validate_email-doc (7098940) withmain (80353c2)

Summary

✅ 44 untouched benchmarks

@github-actionsGitHub Actions
Copy link
Contributor

Coverage report

This PR does not seem to contain any modification to coverable code.

@k4nar
Copy link
ContributorAuthor

please review 🙂

pydantic-hooky[bot] reacted with thumbs up emoji

Copy link
Member

@ViicosViicos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks!

@ViicosViicos merged commit74f224c intopydantic:mainOct 29, 2024
52 checks passed
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@ViicosViicosViicos approved these changes

Assignees

@sydney-runklesydney-runkle

Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@k4nar@Viicos@sydney-runkle
[8]ページ先頭
©2009-2025 Movatter.jp