Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork2.2k
Properly check fortyping_extensions
variant ofTypeAliasType
#10713
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
codspeed-hqbot commentedOct 25, 2024 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
CodSpeed Performance ReportMerging#10713 willnot alter performanceComparing Summary
|
Coverage reportClick to see where and how coverage changed
This report was generated bypython-coverage-comment-action |
please review |
Thanks for the investigation and for the PR. I had this issue in my mind for some time now, and actually there's some other places where we're not careful enough (e.g. |
Sure thing! |
@Viicos I'd appreciate if this gets merged relatively quickly so the daily typing-extensions workflow that runs the pydantic test suite starts passing again. (Of course there are other workarounds; we could temporarily disable the pydantic tests, or just close the issue every day.) |
Ah didn't know that, I'll merge immediately and rebase on my working branch! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Thanks@Daraan
typing
& recenttyping_extensions.TypeAliasType
backport for Python 3.12, 3.13typing_extensions
variant ofTypeAliasType
13979e9
intopydantic:mainUh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Change Summary
Added support for recent
typing_extensions.TypeAliasType
frompython/typing_extensions#477 that cause tests to fail currently.Related issue number
fix#10711
python/typing_extensions#493
Checklist
Selected Reviewer:@sydney-runkle