Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Properly check fortyping_extensions variant ofTypeAliasType#10713

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
Viicos merged 4 commits intopydantic:mainfromDaraan:TypeAliasType-backport
Oct 25, 2024

Conversation

Daraan
Copy link
Contributor

@DaraanDaraan commentedOct 25, 2024
edited
Loading

Change Summary

Added support for recenttyping_extensions.TypeAliasType frompython/typing_extensions#477 that cause tests to fail currently.

Related issue number

fix#10711

python/typing_extensions#493

Checklist

  • The pull request title is a good summary of the changes - it will be used in the changelog
  • Unit tests for the changes exist
  • Tests pass on CI
  • Documentation reflects the changes where applicable
  • My PR is ready to review,please add a comment including the phrase "please review" to assign reviewers

Selected Reviewer:@sydney-runkle

@github-actionsgithub-actionsbot added the relnotes-fixUsed for bugfixes. labelOct 25, 2024
@codspeed-hqCodSpeed HQ
Copy link

codspeed-hqbot commentedOct 25, 2024
edited
Loading

CodSpeed Performance Report

Merging#10713 willnot alter performance

ComparingDaraan:TypeAliasType-backport (373dddd) withmain (12f89be)

Summary

✅ 44 untouched benchmarks

@github-actionsGitHub Actions
Copy link
Contributor

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)
Lines missing
  pydantic/_internal
  _core_utils.py
  _generate_schema.py
  _typing_extra.py604
Project Total 

This report was generated bypython-coverage-comment-action

@DaraanDaraan marked this pull request as ready for reviewOctober 25, 2024 14:21
@Daraan
Copy link
ContributorAuthor

please review

pydantic-hooky[bot] reacted with thumbs up emoji

@Viicos
Copy link
Member

Thanks for the investigation and for the PR. I had this issue in my mind for some time now, and actually there's some other places where we're not careful enough (e.g.is Any checks). Is it fine if I tackle everything in a single PR, adding you as a co-author?

@Daraan
Copy link
ContributorAuthor

Thanks for the investigation and for the PR. I had this issue in my mind for some time now, and actually there's some other places where we're not careful enough (e.g.is Any checks). Is it fine if I tackle everything in a single PR, adding you as a co-author?

Sure thing!

@JelleZijlstra
Copy link
Contributor

@Viicos I'd appreciate if this gets merged relatively quickly so the daily typing-extensions workflow that runs the pydantic test suite starts passing again. (Of course there are other workarounds; we could temporarily disable the pydantic tests, or just close the issue every day.)

@Viicos
Copy link
Member

Ah didn't know that, I'll merge immediately and rebase on my working branch!

JelleZijlstra reacted with heart emoji

Copy link
Member

@ViicosViicos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks@Daraan

Daraan reacted with heart emoji
@ViicosViicos changed the titleDifferentiate betweentyping & recenttyping_extensions.TypeAliasType backport for Python 3.12, 3.13Properly check fortyping_extensions variant ofTypeAliasTypeOct 25, 2024
@ViicosViicos merged commit13979e9 intopydantic:mainOct 25, 2024
52 checks passed
@DaraanDaraan deleted the TypeAliasType-backport branchOctober 25, 2024 16:07
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@ViicosViicosViicos approved these changes

Assignees

@sydney-runklesydney-runkle

Labels
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Recenttyping_extensions.TypeAliasType backport causing tests to fail.
4 participants
@Daraan@Viicos@JelleZijlstra@sydney-runkle

[8]ページ先頭

©2009-2025 Movatter.jp