Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Change JSON schema generation of literals and enums#10692

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
sydney-runkle merged 1 commit intomainfromliteral-enum-js-schema-2
Oct 23, 2024

Conversation

Viicos
Copy link
Member

@ViicosViicos commentedOct 23, 2024•
edited
Loading

Change Summary

Closes#9402

Related issue number

Checklist

  • The pull request title is a good summary of the changes - it will be used in the changelog
  • Unit tests for the changes exist
  • Tests pass on CI
  • Documentation reflects the changes where applicable
  • My PR is ready to review,please add a comment including the phrase "please review" to assign reviewers

@github-actionsgithub-actionsbot added the relnotes-fixUsed for bugfixes. labelOct 23, 2024
@cloudflare-workers-and-pagesCloudflare Workers and Pages

Deploying pydantic-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit:b7b9a11
Status: ✅  Deploy successful!
Preview URL:https://94db0bd4.pydantic-docs.pages.dev
Branch Preview URL:https://literal-enum-js-schema-2.pydantic-docs.pages.dev

View logs

@codspeed-hqCodSpeed HQ
Copy link

CodSpeed Performance Report

Merging#10692 willnot alter performance

Comparingliteral-enum-js-schema-2 (b7b9a11) withmain (bdb04ac)

Summary

✅ 44 untouched benchmarks

@github-actionsGitHub Actions
Copy link
Contributor

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)		Lines missing
  pydantic
  json_schema.py
Project Total 

This report was generated bypython-coverage-comment-action

Copy link
Contributor

@sydney-runklesydney-runkle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Nice work, clean fix.

@sydney-runklesydney-runkle merged commitdc1ee23 intomainOct 23, 2024
61 checks passed
@sydney-runklesydney-runkle deleted the literal-enum-js-schema-2 branchOctober 23, 2024 19:16
frankie567 added a commit to polarsource/polar that referenced this pull requestDec 20, 2024
Pydantic 2.10 removes the `enum` field from JSON schema, which breaks our internal SDK generator. See:pydantic/pydantic#10692
frankie567 added a commit to polarsource/polar that referenced this pull requestDec 20, 2024
Pydantic 2.10 removes the `enum` field from JSON schema, which breaks our internal SDK generator. See:pydantic/pydantic#10692
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@sydney-runklesydney-runklesydney-runkle approved these changes

Assignees
No one assigned
Labels
relnotes-fixUsed for bugfixes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Schema forLiteral differs between version 2.6 and 2.7
2 participants
@Viicos@sydney-runkle
[8]ページ先頭
©2009-2025 Movatter.jp