Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Support default factories taking validated data as an argument#10678

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
Viicos merged 6 commits intomainfromdependent-defaults
Oct 24, 2024

Conversation

Viicos
Copy link
Member

@ViicosViicos commentedOct 21, 2024•
edited
Loading

Change Summary

Closes#9789
Requirespydantic/pydantic-core#1491

Related issue number

Checklist

  • The pull request title is a good summary of the changes - it will be used in the changelog
  • Unit tests for the changes exist
  • Tests pass on CI
  • Documentation reflects the changes where applicable
  • My PR is ready to review,please add a comment including the phrase "please review" to assign reviewers

zzstoatzz reacted with rocket emoji
@github-actionsgithub-actionsbot added the relnotes-fixUsed for bugfixes. labelOct 21, 2024
@cloudflare-workers-and-pagesCloudflare Workers and Pages
Copy link

cloudflare-workers-and-pagesbot commentedOct 21, 2024•
edited
Loading

Deploying pydantic-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit:cf2b4d4
Status: ✅  Deploy successful!
Preview URL:https://e9977517.pydantic-docs.pages.dev
Branch Preview URL:https://dependent-defaults.pydantic-docs.pages.dev

View logs

@ViicosViicosforce-pushed thedependent-defaults branch 2 times, most recently from7e98130 toed49703CompareOctober 22, 2024 14:10
@codspeed-hqCodSpeed HQ
Copy link

codspeed-hqbot commentedOct 22, 2024•
edited
Loading

CodSpeed Performance Report

Merging#10678 willnot alter performance

Comparingdependent-defaults (cf2b4d4) withmain (af32a86)

Summary

✅ 44 untouched benchmarks

@ViicosViicosforce-pushed thedependent-defaults branch 4 times, most recently fromd8c3d05 tod5ec070CompareOctober 23, 2024 09:53
@github-actionsGitHub Actions
Copy link
Contributor

github-actionsbot commentedOct 23, 2024•
edited
Loading

Coverage report

This PR does not seem to contain any modification to coverable code.

@ViicosViicos marked this pull request as ready for reviewOctober 23, 2024 10:25
@Viicos
Copy link
MemberAuthor

I haven't documented theexclude_defaults behavior as it seems pretty niche

sydney-runkle reacted with thumbs up emoji

Copy link
Contributor

@sydney-runklesydney-runkle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Nice work! One minor question.

Thanks for adding the section to the concepts docs, looks great.

@ViicosViicosenabled auto-merge (squash)October 24, 2024 19:30
@ViicosViicos merged commit12f89be intomainOct 24, 2024
54 checks passed
@ViicosViicos deleted the dependent-defaults branchOctober 24, 2024 19:37
@ViicosViicos mentioned this pull requestOct 25, 2024
13 tasks
@milani
Copy link

Thanks for adding this! Can PrivateAttr'sdefault_factory work the same way?

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@sydney-runklesydney-runklesydney-runkle approved these changes

Assignees
No one assigned
Labels
relnotes-fixUsed for bugfixes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow access to other field values when creating a default value
3 participants
@Viicos@milani@sydney-runkle
[8]ページ先頭
©2009-2025 Movatter.jp