Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Mark mypy integration tests as flaky again in CI#10677

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
Viicos merged 2 commits intopydantic:mainfrommschoettle:fix-typechecking-ignore
Oct 21, 2024

Conversation

mschoettle
Copy link
Contributor

@mschoettlemschoettle commentedOct 21, 2024•
edited by pydantic-hookybot
Loading

Change Summary

The typechecking job fails due to an unusedtype: ignore[...]. See:https://github.com/pydantic/pydantic/actions/runs/11446111308/job/31844612840?pr=10676

This PR removes this comment.

Related issue number

Checklist

  • The pull request title is a good summary of the changes - it will be used in the changelog
  • Unit tests for the changes exist
  • Tests pass on CI
  • Documentation reflects the changes where applicable
  • My PR is ready to review,please add a comment including the phrase "please review" to assign reviewers

Selected Reviewer:@sydney-runkle

@github-actionsgithub-actionsbot added the relnotes-fixUsed for bugfixes. labelOct 21, 2024
@codspeed-hqCodSpeed HQ
Copy link

codspeed-hqbot commentedOct 21, 2024•
edited
Loading

CodSpeed Performance Report

Merging#10677 willnot alter performance

Comparingmschoettle:fix-typechecking-ignore (c365a7e) withmain (6681c00)

Summary

✅ 44 untouched benchmarks

@github-actionsGitHub Actions
Copy link
Contributor

Coverage report

This PR does not seem to contain any modification to coverable code.

@mschoettle
Copy link
ContributorAuthor

please review

pydantic-hooky[bot] reacted with thumbs up emoji

@Viicos
Copy link
Member

Ok so turns out the test is still flaky. It was enabled today in#10671. Could you please instead re-add the same conditionhere? I'll debug in a separate PR.

@mschoettlemschoettle changed the titleRemove unused mypy type ignoreMark mypy integration tests as flaky again in CIOct 21, 2024
@mschoettle
Copy link
ContributorAuthor

@Viicos Okay, that explains why it suddenly appeared again. Changed as requested.

Copy link
Member

@ViicosViicos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks!

@ViicosViicosenabled auto-merge (squash)October 21, 2024 20:09
@ViicosViicos merged commite7cfe9e intopydantic:mainOct 21, 2024
58 checks passed
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@ViicosViicosViicos approved these changes

Assignees

@sydney-runklesydney-runkle

Labels
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@mschoettle@Viicos@sydney-runkle
[8]ページ先頭
©2009-2025 Movatter.jp