Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Clean up themypy plugin implementation#10669

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
Viicos merged 1 commit intomainfromcleanup-mypy-plugin
Oct 21, 2024
Merged

Conversation

Viicos
Copy link
Member

@ViicosViicos commentedOct 21, 2024•
edited
Loading

Remove old versions compatibility branches, improve type checking

Closes#10197

Change Summary

Related issue number

Checklist

  • The pull request title is a good summary of the changes - it will be used in the changelog
  • Unit tests for the changes exist
  • Tests pass on CI
  • Documentation reflects the changes where applicable
  • My PR is ready to review,please add a comment including the phrase "please review" to assign reviewers

@github-actionsgithub-actionsbot added the relnotes-fixUsed for bugfixes. labelOct 21, 2024
Remove old versions compatibility branches, improve type checking
@cloudflare-workers-and-pagesCloudflare Workers and Pages
Copy link

cloudflare-workers-and-pagesbot commentedOct 21, 2024•
edited
Loading

Deploying pydantic-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit:9bd2580
Status: ✅  Deploy successful!
Preview URL:https://dffe7415.pydantic-docs.pages.dev
Branch Preview URL:https://cleanup-mypy-plugin.pydantic-docs.pages.dev

View logs

@codspeed-hqCodSpeed HQ
Copy link

codspeed-hqbot commentedOct 21, 2024•
edited
Loading

CodSpeed Performance Report

Merging#10669 willnot alter performance

Comparingcleanup-mypy-plugin (9bd2580) withmain (a1ffc82)

Summary

✅ 44 untouched benchmarks

@github-actionsGitHub Actions
Copy link
Contributor

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)		Lines missing
  pydantic
  mypy.py
Project Total 

This report was generated bypython-coverage-comment-action

Copy link
Contributor

@sydney-runklesydney-runkle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Awesome. Happy to merge this.

Can we uncomment the skip for mypy type checking tests? Doesn't block this merge, but I don't want to forget about it.

@ViicosViicos merged commitd183bf5 intomainOct 21, 2024
60 checks passed
@ViicosViicos deleted the cleanup-mypy-plugin branchOctober 21, 2024 11:11
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@sydney-runklesydney-runklesydney-runkle approved these changes

Assignees
No one assigned
Labels
relnotes-fixUsed for bugfixes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update supportedmypy versions for the Pydantic plugin
2 participants
@Viicos@sydney-runkle
[8]ページ先頭
©2009-2025 Movatter.jp