Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork2.2k
docs: respect system colorscheme#10667
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
docs: respect system colorscheme#10667
Uh oh!
There was an error while loading.Please reload this page.
Conversation
The docs now use the systems color preference by default. A new thirdoption was added to the theme picker, which automatically adjusts thelight/dark mode.
CodSpeed Performance ReportMerging#10667 willnot alter performanceComparing Summary
|
please review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Thanks for adding the video example. This looks good
220b2f6
intopydantic:mainUh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Change Summary
Screen.Recording.2024-10-20.at.22.45.41.mov
This PR makes the docs respect the systems color preference by default. As can be seen in the video, it currently defaults to light mode, even if I've set my OS to dark mode.
This also adds a new option to the theme picker next to the search. This means the cycle is now
Related issue number
Not an issue, but the dark mode seems to have been introduced in#2913. The convention that the button icon and alt text reflects theaction instead of the current state is retained. The latest comment on the referenced PR also indicates that other users also expect the systems color preference to be the default.
Other Related Things
Here is a link to the docs of Mkdocs Material, where they describe the automatic dark/light mode:https://squidfunk.github.io/mkdocs-material/setup/changing-the-colors/#automatic-light-dark-mode
Checklist
Unit tests for the changes existDocumentation reflects the changes where applicableSelected Reviewer:@sydney-runkle