Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Use overloads forField andPrivateAttr functions#10651

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
Viicos merged 4 commits intomainfromfields-func-overloads
Oct 18, 2024

Conversation

Viicos
Copy link
Member

This typechecks thedefault anddefault_factory arguments, and removes the need for a custom mypy plugin hook.

Change Summary

Related issue number

Checklist

  • The pull request title is a good summary of the changes - it will be used in the changelog
  • Unit tests for the changes exist
  • Tests pass on CI
  • Documentation reflects the changes where applicable
  • My PR is ready to review,please add a comment including the phrase "please review" to assign reviewers

This typechecks the `default` and `default_factory` arguments,and removes the need for a custom mypy plugin hook.
@github-actionsgithub-actionsbot added the relnotes-fixUsed for bugfixes. labelOct 17, 2024
@ViicosViicos mentioned this pull requestOct 17, 2024
5 tasks
@cloudflare-workers-and-pagesCloudflare Workers and Pages
Copy link

cloudflare-workers-and-pagesbot commentedOct 17, 2024•
edited
Loading

Deploying pydantic-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit:60e97ce
Status: ✅  Deploy successful!
Preview URL:https://3e80c252.pydantic-docs.pages.dev
Branch Preview URL:https://fields-func-overloads.pydantic-docs.pages.dev

View logs

@codspeed-hqCodSpeed HQ
Copy link

codspeed-hqbot commentedOct 17, 2024•
edited
Loading

CodSpeed Performance Report

Merging#10651 willnot alter performance

Comparingfields-func-overloads (60e97ce) withmain (0359a21)

Summary

✅ 44 untouched benchmarks

Copy link
Contributor

@sydney-runklesydney-runkle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Nice work, much cleaner!

@sydney-runkle
Copy link
Contributor

Pending happymypy, I'm good with this 👍

@github-actionsGitHub Actions
Copy link
Contributor

github-actionsbot commentedOct 18, 2024•
edited
Loading

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)		Lines missing
  pydantic
  fields.py
  pydantic/_internal
  _model_construction.py
Project Total 

This report was generated bypython-coverage-comment-action

@sydney-runkle
Copy link
Contributor

Update: disabledmypy tests bc they're being flaky. We will investigate before closing#10623

@ViicosViicos merged commit06a04b5 intomainOct 18, 2024
62 checks passed
@ViicosViicos deleted the fields-func-overloads branchOctober 18, 2024 17:57
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@sydney-runklesydney-runklesydney-runkle approved these changes

Assignees
No one assigned
Labels
relnotes-fixUsed for bugfixes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@Viicos@sydney-runkle
[8]ページ先頭
©2009-2025 Movatter.jp