NotificationsYou must be signed in to change notification settings
Fork2.2k
Star24.6k

Tweak type alias logics#10643

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

Viicos merged 3 commits intopydantic:mainfromkc0506:tweak-type-alias

Oct 17, 2024

Merged

Tweak type alias logics#10643

Viicos merged 3 commits intopydantic:mainfromkc0506:tweak-type-alias

Oct 17, 2024

Conversation

Copy link

Contributor

kc0506 commentedOct 17, 2024•
edited
Loading

Change Summary

Put type alias logic afterfrom_property.

Related issue number

Checklist

The pull request title is a good summary of the changes - it will be used in the changelog
Unit tests for the changes exist
Tests pass on CI
Documentation reflects the changes where applicable
My PR is ready to review,please add a comment including the phrase "please review" to assign reviewers

Tweak type alias

1629428

github-actionsbot added the relnotes-fixUsed for bugfixes. label

Oct 17, 2024

Copy link

codspeed-hqbot commentedOct 17, 2024•
edited
Loading

CodSpeed Performance Report

Merging#10643 willnot alter performance

_{Comparingkc0506:tweak-type-alias (5ebb0ed) withmain (7bb0e0a)}

Summary

✅ 44 untouched benchmarks

put GenericAlias under TYPE_CHECKING

3eafd62

Copy link

Contributor

sydney-runkle commentedOct 17, 2024

@Viicos, could you take a look at this one? You've had your head in this space recently...

sydney-runkle requested a review fromViicos

October 17, 2024 09:27

Copy link

Contributor

github-actionsbot commentedOct 17, 2024•
edited
Loading

Coverage report

Click to see where and how coverage changed

File	Statements	Missing	Coverage	Coverage (new stmts)	Lines missing
pydantic/_internal
_generate_schema.py
Project Total

_{This report was generated bypython-coverage-comment-action}

Viicos reviewed

Oct 17, 2024

View reviewed changes

pydantic/_internal/_generate_schema.py OutdatedShow resolvedHide resolved

pydantic/_internal/_generate_schema.py

Comment on lines +1041 to +1042

		if isinstance(origin, TypeAliasType):
		return self._type_alias_type_schema(obj)

Copy link

Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Why was it moved?

Copy link

ContributorAuthor

kc0506Oct 17, 2024•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I think without a special reason (e.g.dataclass above), these matching clauses should better be put together to make things clearer. Looks like whenorigin is of typeTypeAliasType,from_property is alwaysNone (at least in the current tests), so moving it does not have any actual effect.