NotificationsYou must be signed in to change notification settings
Fork2.2k
Star24.6k

Add runtime validation of`@validate_call` callable argument#10627

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

Viicos merged 1 commit intomainfromvalidate-call-runtime-tc

Oct 15, 2024

Merged

Add runtime validation of`@validate_call` callable argument#10627

Viicos merged 1 commit intomainfromvalidate-call-runtime-tc

Oct 15, 2024

Conversation

Copy link

Member

Viicos commentedOct 14, 2024•
edited
Loading

Change Summary

Wrapping up#10484
Closes#10461

Related issue number

Checklist

The pull request title is a good summary of the changes - it will be used in the changelog
Unit tests for the changes exist
Tests pass on CI
Documentation reflects the changes where applicable
My PR is ready to review,please add a comment including the phrase "please review" to assign reviewers

Add runtime validation of@validate_call callable argument

cc74d42

github-actionsbot added the relnotes-fixUsed for bugfixes. label

Oct 14, 2024

Copy link

cloudflare-workers-and-pagesbot commentedOct 14, 2024

Deploying pydantic-docs with Cloudflare Pages

Latest commit:	`cc74d42`
Status:	✅ Deploy successful!
Preview URL:	https://bb03277e.pydantic-docs.pages.dev
Branch Preview URL:	https://validate-call-runtime-tc.pydantic-docs.pages.dev

View logs

Viicos mentioned this pull request

Oct 14, 2024

Add runtime type-checking forvalidate_call#10484

Closed

5 tasks

Copy link

codspeed-hqbot commentedOct 14, 2024

CodSpeed Performance Report

Merging#10627 willnot alter performance

_{Comparingvalidate-call-runtime-tc (cc74d42) withmain (60f7047)}

Summary

✅ 44 untouched benchmarks

Viicos added relnotes-feature and removed relnotes-fixUsed for bugfixes. labels

Oct 14, 2024

Viicosenabled auto-merge (squash)

October 14, 2024 20:09

Copy link

Contributor

github-actionsbot commentedOct 14, 2024

Coverage report

Click to see where and how coverage changed

File	Statements	Missing	Coverage	Coverage (new stmts)	Lines missing
pydantic
validate_call_decorator.py
pydantic/_internal
_generate_schema.py
_validate_call.py
Project Total

_{This report was generated bypython-coverage-comment-action}

sydney-runkle approved these changes

Oct 15, 2024

View reviewed changes

Copy link

Contributor

sydney-runkle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM, but would like answers to a few questions before we merge.

Thanks@Viicos for finishing this up, and thanks@kc0506 for your work on the initial changes here!

pydantic/_internal/_validate_call.py

		'__name__',
		'__qualname__',
		'__annotations__',
		'__dict__', # required for __module__

Copy link

Contributor

sydney-runkleOct 15, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Have we thought about the consequences of removing this?

Copy link

MemberAuthor

ViicosOct 15, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

__name__ was necessary for the core_config title thing but#10562 made it not necessary anymore. For the rest, I don't think it will change anything.