Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Fixvalidate_call ignoringField inAnnotated#10610

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

kc0506
Copy link
Contributor

@kc0506kc0506 commentedOct 12, 2024•
edited by Viicos
Loading

Change Summary

Related issue number

fix#10569

edit:fix#10610.

Checklist

  • The pull request title is a good summary of the changes - it will be used in the changelog
  • Unit tests for the changes exist
  • Tests pass on CI
  • Documentation reflects the changes where applicable
  • My PR is ready to review,please add a comment including the phrase "please review" to assign reviewers

@github-actionsgithub-actionsbot added the relnotes-fixUsed for bugfixes. labelOct 12, 2024
@github-actionsGitHub Actions
Copy link
Contributor

github-actionsbot commentedOct 12, 2024•
edited
Loading

Coverage report

This PR does not seem to contain any modification to coverable code.

Copy link
Contributor

@sydney-runklesydney-runkle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Good find, thanks@kc0506!

@codspeed-hqCodSpeed HQ
Copy link

CodSpeed Performance Report

Merging#10610 willnot alter performance

Comparingkc0506:fix-validate-call-annotated (a2f6c55) withmain (28662ff)

Summary

✅ 38 untouched benchmarks

@sydney-runklesydney-runkleenabled auto-merge (squash)October 13, 2024 11:18
@sydney-runklesydney-runkle merged commit2b2dffc intopydantic:mainOct 13, 2024
58 checks passed
@kc0506kc0506 deleted the fix-validate-call-annotated branchOctober 14, 2024 10:05
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@sydney-runklesydney-runklesydney-runkle approved these changes

Assignees
No one assigned
Labels
relnotes-fixUsed for bugfixes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

validate_call appears to ignore discriminated Unions
2 participants
@kc0506@sydney-runkle
[8]ページ先頭
©2009-2025 Movatter.jp