Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Raise an error whenSelf is invalid#10609

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
Viicos merged 6 commits intopydantic:mainfromkc0506:add-invalid-self-error
Oct 14, 2024

Conversation

kc0506
Copy link
Contributor

@kc0506kc0506 commentedOct 12, 2024•
edited
Loading

Change Summary

Raise an error whenSelf is used butself.model_type_stack.get() returnsNone.

Related issue number

Checklist

  • The pull request title is a good summary of the changes - it will be used in the changelog
  • Unit tests for the changes exist
  • Tests pass on CI
  • Documentation reflects the changes where applicable
  • My PR is ready to review,please add a comment including the phrase "please review" to assign reviewers

@github-actionsgithub-actionsbot added the relnotes-fixUsed for bugfixes. labelOct 12, 2024
@github-actionsGitHub Actions
Copy link
Contributor

github-actionsbot commentedOct 12, 2024•
edited
Loading

Coverage report

This PR does not seem to contain any modification to coverable code.

Copy link
Contributor

@sydney-runklesydney-runkle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks@kc0506!

I'm happy with this change. Let's check what@Viicos thinks before we merge.

@codspeed-hqCodSpeed HQ
Copy link

codspeed-hqbot commentedOct 13, 2024•
edited
Loading

CodSpeed Performance Report

Merging#10609 willnot alter performance

Comparingkc0506:add-invalid-self-error (8d47aba) withmain (1940011)

Summary

✅ 44 untouched benchmarks

Co-authored-by: Sydney Runkle <54324534+sydney-runkle@users.noreply.github.com>
@ViicosViicosenabled auto-merge (squash)October 14, 2024 08:23
@Viicos
Copy link
Member

Thanks@kc0506

@ViicosViicos merged commit6d3717c intopydantic:mainOct 14, 2024
59 checks passed
@kc0506kc0506 deleted the add-invalid-self-error branchOctober 14, 2024 10:05
@kc0506kc0506 mentioned this pull requestOct 18, 2024
13 tasks
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@ViicosViicosViicos left review comments

@sydney-runklesydney-runklesydney-runkle approved these changes

Assignees
No one assigned
Labels
relnotes-fixUsed for bugfixes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@kc0506@Viicos@sydney-runkle
[8]ページ先頭
©2009-2025 Movatter.jp