please review

CodSpeed Performance Report

Merging#10601 willnot alter performance

_{ComparingAlekseyLobanov:fix.email-regex (e35c507) withmain (c772b43)}

Summary

✅ 38 untouched benchmarks

How performance changes?
I use my own POC in#10600 and run it as/usr/bin/time python pydantic-poc.py 500

• Before: 5.35user 0.01system 0:05.37elapsed 99%CPU (0avgtext+0avgdata 36840maxresident)k
• After: 0.20user 0.01system 0:00.22elapsed 99%CPU (0avgtext+0avgdata 37004maxresident)k

About25x speed improvement.

Coverage report

This PR does not seem to contain any modification to coverable code.

Thanks, this looks reasonable but to be extra careful we'll wait for other reviews as well.

According toWikipedia it is one of the valid DoS attack vectors. And at least some of known to me rate limiters will work onlyafter validation step.

Could you add the following to the test_address_valid test?

I think that existing tests are already covering this edge cases (spaces before/after the group). Should I still add yours?

        ('foo BAR <foobar@example.com >','foo BAR','foobar@example.com'),        ('FOO bar   <foobar@example.com> ','FOO bar','foobar@example.com'),        ('Whatever < foobar@example.com>','Whatever','foobar@example.com'),

Yep let's add those extra tests and fix the lints, but otherwise LGTM.

According toWikipedia it is one of the valid DoS attack vectors. And at least some of known to me rate limiters will work onlyafter validation step.

I agree, just wanted to be careful as changing regex can be a source of breaking changes.

I think that existing tests are already covering this edge cases (spaces before/after the group). Should I still add yours?

Missed these ones, then maybe only add these ones after it:

        ('Whatever <foobar@example.com >','Whatever','foobar@example.com'),        ('Whatever < foobar@example.com >','Whatever','foobar@example.com'),

Missed these ones, then maybe only add these ones after it:

Done.