Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Expose publicsort method for JSON schema generation#10595

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
sydney-runkle merged 6 commits intomainfromsorting-for-good-hopefully
Oct 10, 2024

Conversation

sydney-runkle
Copy link
Contributor

@sydney-runklesydney-runkle commentedOct 10, 2024
edited
Loading

Closes#7580

At first, thought we might have to add a flag to fix this. The way I feel about adding flags at this point is about howedna (from The Incredibles) feels about capes.

Luckily, was able to sidestep the need for a flag by exposing the sort method as a public one in theGenerateJsonSchema class.

Did a little bit of refactoring to make things more type checking friendly re the outer sort vs recursive sorts. I did the move -> public and refactoring in different commits, so should be easy to review. Also added a docs example to expose the customizability here. Yay for empowered users!

@cloudflare-workers-and-pagesCloudflare Workers and Pages
Copy link

cloudflare-workers-and-pagesbot commentedOct 10, 2024
edited
Loading

Deploying pydantic-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit:12cc428
Status: ✅  Deploy successful!
Preview URL:https://756056c8.pydantic-docs.pages.dev
Branch Preview URL:https://sorting-for-good-hopefully.pydantic-docs.pages.dev

View logs

@codspeed-hqCodSpeed HQ
Copy link

codspeed-hqbot commentedOct 10, 2024
edited
Loading

CodSpeed Performance Report

Merging#10595 willnot alter performance

Comparingsorting-for-good-hopefully (12cc428) withmain (09ade35)

Summary

✅ 38 untouched benchmarks

@github-actionsGitHub Actions
Copy link
Contributor

github-actionsbot commentedOct 10, 2024
edited
Loading

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)
Lines missing
  pydantic
  json_schema.py
Project Total 

This report was generated bypython-coverage-comment-action

Copy link
Member

@ViicosViicos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM

Co-authored-by: Victorien <65306057+Viicos@users.noreply.github.com>
@sydney-runklesydney-runkle merged commit07e2b72 intomainOct 10, 2024
63 checks passed
@sydney-runklesydney-runkle deleted the sorting-for-good-hopefully branchOctober 10, 2024 15:39
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@adriangbadriangbadriangb left review comments

@ViicosViicosViicos approved these changes

Assignees
No one assigned
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Order of keys differs in schema output
3 participants
@sydney-runkle@adriangb@Viicos

[8]ページ先頭

©2009-2025 Movatter.jp