Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Do not use the previous config from the stack for dataclasses without config#10576

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
Viicos merged 2 commits intomainfromdataclass-config-bug
Oct 8, 2024

Conversation

Viicos
Copy link
Member

@ViicosViicos commentedOct 8, 2024•
edited
Loading

Change Summary

Also fixed in#10530 but in a separate PR for a cleaner commit history.

Related issue number

Checklist

  • The pull request title is a good summary of the changes - it will be used in the changelog
  • Unit tests for the changes exist
  • Tests pass on CI
  • Documentation reflects the changes where applicable
  • My PR is ready to review,please add a comment including the phrase "please review" to assign reviewers

@ViicosViicos changed the titleDo not use the previous config from the stack for dataclasses without…Do not use the previous config from the stack for dataclasses without configOct 8, 2024
@github-actionsgithub-actionsbot added the relnotes-fixUsed for bugfixes. labelOct 8, 2024
@cloudflare-workers-and-pagesCloudflare Workers and Pages
Copy link

cloudflare-workers-and-pagesbot commentedOct 8, 2024•
edited
Loading

Deploying pydantic-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit:db5e36c
Status: ✅  Deploy successful!
Preview URL:https://f5fda88c.pydantic-docs.pages.dev
Branch Preview URL:https://dataclass-config-bug.pydantic-docs.pages.dev

View logs

@codspeed-hqCodSpeed HQ
Copy link

codspeed-hqbot commentedOct 8, 2024•
edited
Loading

CodSpeed Performance Report

Merging#10576 willnot alter performance

Comparingdataclass-config-bug (db5e36c) withmain (bb7bd96)

Summary

✅ 38 untouched benchmarks

Copy link
Contributor

@sydney-runklesydney-runkle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Good find, thanks!

@github-actionsGitHub Actions
Copy link
Contributor

github-actionsbot commentedOct 8, 2024•
edited
Loading

Coverage report

This PR does not seem to contain any modification to coverable code.

@sydney-runkle
Copy link
Contributor

Maybe we add a test demonstrating that this is not allowed?

@dataclasses.dataclassclassDC:a:ArbitraryTypeb:strclassModel(BaseModel):model_config=ConfigDict(arbitrary_types_allowed=True)dc:DCother:str

@ViicosViicosenabled auto-merge (squash)October 8, 2024 15:26
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@sydney-runklesydney-runklesydney-runkle approved these changes

Assignees
No one assigned
Labels
relnotes-fixUsed for bugfixes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@Viicos@sydney-runkle
[8]ページ先頭
©2009-2025 Movatter.jp