Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Add unit tests for ImportError handling and ValidationError on unbound SocketPath#10555

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

tkasuz
Copy link
Contributor

@tkasuztkasuz commentedOct 5, 2024•
edited by pydantic-hookybot
Loading

Change Summary

This PR introduces new unit tests to enhance the test coverage by covering the following scenarios:

ValidationError for Unbound SocketPath:

Added a unit test to verify that aValidationError is raised when the provided path is not bound by a socket. This ensures that the application correctly handles and reports errors related to unbound socket paths.

ImportError Handling for email-validator

Introduced unit tests to verify the proper handling of ImportError scenarios related to the email-validator package. Specifically, the tests cover:

  • The expectedImportError whenemail-validator is not installed.
  • The handling ofImportError when there is an invalid installation ofemail-validator.

Related to#7656

Checklist

  • The pull request title is a good summary of the changes - it will be used in the changelog
  • Unit tests for the changes exist
  • Tests pass on CI
  • Documentation reflects the changes where applicable
  • My PR is ready to review,please add a comment including the phrase "please review" to assign reviewers

Selected Reviewer:@sydney-runkle

sydney-runkle reacted with heart emoji
This commit introduces a unit test that verifies a ValidationError is raised when the provided path is not bound by a socket.
This commit introduces unit tests to verify the proper handling of ImportError scenarios related to the email-validator package. Specifically, it tests:- The expected ImportError when email-validator is not installed- The handling of ImportError when there is an invalid installation of email-validator
@github-actionsgithub-actionsbot added the relnotes-fixUsed for bugfixes. labelOct 5, 2024
@codspeed-hqCodSpeed HQ
Copy link

CodSpeed Performance Report

Merging#10555 willnot alter performance

Comparingtkasuz:increase_types_test_coverage (0adb62a) withmain (eda3eb4)

Summary

✅ 38 untouched benchmarks

@github-actionsGitHub Actions
Copy link
Contributor

Coverage report

This PR does not seem to contain any modification to coverable code.

@tkasuz
Copy link
ContributorAuthor

please review

pydantic-hooky[bot] reacted with thumbs up emoji

Copy link
Contributor

@sydney-runklesydney-runkle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Nice work!!

Thanks for the help here :)

@sydney-runklesydney-runkle added relnotes-ignoreOmit this PR from the release notes. and removed relnotes-fixUsed for bugfixes. labelsOct 7, 2024
@sydney-runklesydney-runkle merged commit114c914 intopydantic:mainOct 7, 2024
60 checks passed
@tkasuztkasuz deleted the increase_types_test_coverage branchNovember 4, 2024 02:43
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@sydney-runklesydney-runklesydney-runkle approved these changes

Assignees

@sydney-runklesydney-runkle

Labels
ready for reviewrelnotes-ignoreOmit this PR from the release notes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@tkasuz@sydney-runkle
[8]ページ先頭
©2009-2025 Movatter.jp