Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Usingcore_schema.InvalidSchema instead of metadata injection + checks#10523

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
sydney-runkle merged 7 commits intomainfrominvalid-schema
Oct 15, 2024

Conversation

sydney-runkle
Copy link
Contributor

@sydney-runklesydney-runkle commentedSep 30, 2024•
edited
Loading

Making progress on#10299
Requirespydantic/pydantic-core#1469

@cloudflare-workers-and-pagesCloudflare Workers and Pages
Copy link

cloudflare-workers-and-pagesbot commentedOct 11, 2024•
edited
Loading

Deploying pydantic-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit:2e2c059
Status: ✅  Deploy successful!
Preview URL:https://32c7bc58.pydantic-docs.pages.dev
Branch Preview URL:https://invalid-schema.pydantic-docs.pages.dev

View logs

@codspeed-hqCodSpeed HQ
Copy link

codspeed-hqbot commentedOct 11, 2024•
edited
Loading

CodSpeed Performance Report

Merging#10523 willnot alter performance

Comparinginvalid-schema (2e2c059) withmain (ba50d94)

Summary

✅ 44 untouched benchmarks

@github-actionsGitHub Actions
Copy link
Contributor

github-actionsbot commentedOct 11, 2024•
edited
Loading

Coverage report

This PR does not seem to contain any modification to coverable code.

@sydney-runkle
Copy link
ContributorAuthor

A bit stumped here.@davidhewitt, maybe we could chat on Monday. Do you think it makes sense to haveInvalidSchema as a member of theCoreSchema type alias? It doesn't have aserialization key, which is throwing off the type checker in cases where we applyschema['serialization'] to aCoreSchema instance...

Going to pause dev here until we've made a decision on that front.

@sydney-runklesydney-runkleenabled auto-merge (squash)October 15, 2024 15:31
@sydney-runklesydney-runkle merged commit51cf3cb intomainOct 15, 2024
61 checks passed
@sydney-runklesydney-runkle deleted the invalid-schema branchOctober 15, 2024 15:42
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@ViicosViicosViicos approved these changes

@davidhewittdavidhewittAwaiting requested review from davidhewitt

Assignees
No one assigned
Labels
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@sydney-runkle@Viicos
[8]ページ先頭
©2009-2025 Movatter.jp