frompydantic.dataclassesimportdataclassaspd_dcfromdataclassesimportdataclassasstdlib_dc@pd_dcclassA:a:int@stdlib_dcclassB(A):b:strB.__pydantic_core_schema__#> Core schema of `A`

Until now, we had theexisting_schema.get('cls', None) is obj check to avoid incorrectly using the core schema in this case. However, this doesn't work if the core schema is of typedefinitions, in which caseexisting_schema.get('cls', None) is obj isFalse even though it is the correct schema. This was found during the ns refactor.

Change Summary

Related issue number

Checklist

The pull request title is a good summary of the changes - it will be used in the changelog
Unit tests for the changes exist
Tests pass on CI
Documentation reflects the changes where applicable
My PR is ready to review,please add a comment including the phrase "please review" to assign reviewers

github-actionsbot added the relnotes-fixUsed for bugfixes. label

Sep 30, 2024

Viicos commented

Sep 30, 2024

View reviewed changes

pydantic/_internal/_generate_schema.py

		@@ -813,9 +813,12 @@ def _generate_schema_from_property(self, obj: Any, source: Any) -> core_schema.C
		source, CallbackGetCoreSchemaHandler(self._generate_schema_inner, self, ref_mode=ref_mode)
		)
		elif (
		(existing_schema := getattr(obj, '__pydantic_core_schema__', None)) is not None
		hasattr(obj, '__dict__')

Copy link

MemberAuthor

ViicosSep 30, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

We could also check for__slots__ but there's no such type with a__pydantic_core_schema__ property as of today, so I'm keeping things simple here by only checking for__dict__

Only fetch__pydantic_core_schema__ from the current class during s…

8dff26d

…chema generation

Viicos force-pushed thegen-schema-from-property-dict branch from3f853bb to8dff26dCompare

September 30, 2024 15:00

Copy link

cloudflare-workers-and-pagesbot commentedSep 30, 2024•
edited
Loading

Deploying pydantic-docs with Cloudflare Pages

Latest commit:	`8dff26d`
Status:	✅ Deploy successful!
Preview URL:	https://1988b6bf.pydantic-docs.pages.dev
Branch Preview URL:	https://gen-schema-from-property-dic.pydantic-docs.pages.dev

View logs