Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork2.2k
Useb64decode
andb64encode
forBase64Bytes
type#10486
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
cloudflare-workers-and-pagesbot commentedSep 25, 2024 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Deploying pydantic-docs with |
Latest commit: | 3b80ba9 |
Status: | ✅ Deploy successful! |
Preview URL: | https://617bf15e.pydantic-docs.pages.dev |
Branch Preview URL: | https://base-64-bytes-fix.pydantic-docs.pages.dev |
codspeed-hqbot commentedSep 25, 2024 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
CodSpeed Performance ReportMerging#10486 willnot alter performanceComparing Summary
|
One lingering concern that I have here is the failing test relating to round tripping: frompydanticimportBaseModel,Base64Bytesinput_data=b'Zm9vIGJhcg==\n'expected_value=b'foo bar'classModel(BaseModel):base64_value:Base64Bytesm=Model(base64_value=input_data)assertm.base64_value==expected_valueassertm.model_dump()['base64_value']==input_data# b'Zm9vIGJhcg==' != b'Zm9vIGJhcg==\n' |
Uh oh!
There was an error while loading.Please reload this page.
b64decode
andb64encode
forBase64Bytes
type
We've discussed - this isn't an issue, the whole point was to move to the newer function not adding a newline automatically. Validation still succeeds, so round tripping is fine. This is similar to url behavior, etc. |
Coverage reportClick to see where and how coverage changed
This report was generated bypython-coverage-comment-action |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
nice!
e838139
intomainUh oh!
There was an error while loading.Please reload this page.
Thank you@sydney-runkle, this is fantastic! |
Closes#9072
Change that should be highlighted in the upcoming release notes + blog post.