Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Fix schema generation error when serialization schema holds references#10444

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
sydney-runkle merged 1 commit intomainfrom10443
Sep 19, 2024

Conversation

Viicos
Copy link
Member

Change Summary

Fixes#10443.
I'm not too happy with the solution, feels a bit weird to have to worry about this insidecount_refs, but couldn't find a better fix.

Checklist

  • The pull request title is a good summary of the changes - it will be used in the changelog
  • Unit tests for the changes exist
  • Tests pass on CI
  • Documentation reflects the changes where applicable
  • My PR is ready to review,please add a comment including the phrase "please review" to assign reviewers

@github-actionsgithub-actionsbot added the relnotes-fixUsed for bugfixes. labelSep 19, 2024
@cloudflare-workers-and-pagesCloudflare Workers and Pages

Deploying pydantic-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit:6f29c68
Status: ✅  Deploy successful!
Preview URL:https://1af52f31.pydantic-docs.pages.dev
Branch Preview URL:https://10443.pydantic-docs.pages.dev

View logs

@codspeed-hqCodSpeed HQ
Copy link

CodSpeed Performance Report

Merging#10444 willimprove performances by 13.81%

Comparing10443 (6f29c68) withmain (01daafa)

Summary

⚡ 1 improvements
✅ 36 untouched benchmarks

Benchmarks breakdown

Benchmarkmain10443Change
⚡test_field_validators_serializers2.8 ms2.5 ms+13.81%

@github-actionsGitHub Actions
Copy link
Contributor

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)		Lines missing
  pydantic/_internal
  _core_utils.py
Project Total 

This report was generated bypython-coverage-comment-action

Copy link
Contributor

@sydney-runklesydney-runkle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Seems alright to me for now, thanks for adding the inline comment.

@sydney-runklesydney-runkle merged commit61818e2 intomainSep 19, 2024
62 checks passed
@sydney-runklesydney-runkle deleted the 10443 branchSeptember 19, 2024 13:42
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@sydney-runklesydney-runklesydney-runkle approved these changes

Assignees
No one assigned
Labels
relnotes-fixUsed for bugfixes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Schema generation error when serialization schema holds a reference
2 participants
@Viicos@sydney-runkle
[8]ページ先頭
©2009-2025 Movatter.jp