Decided not to warn on method overrides, as that's an incredibly common practice in Python, and type checking does enough warning here in cases of incompatibility.

sydney-runkle added the relnotes-changeUsed for changes to existing functionality which don't have a better categorization. label

Sep 18, 2024

hyperlint-aibot reviewed

Sep 18, 2024

View reviewed changes

Copy link

Contributor

hyperlint-aibot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

1 files reviewed, 1 outstanding issue(s) found.

docs/concepts/serialization.md OutdatedShow resolvedHide resolved

sydney-runkle commented

Sep 18, 2024

View reviewed changes

pydantic/_internal/_model_construction.py OutdatedShow resolvedHide resolved

Copy link

cloudflare-workers-and-pagesbot commentedSep 18, 2024•
edited
Loading

Deploying pydantic-docs with Cloudflare Pages

Latest commit:	`36a7816`
Status:	✅ Deploy successful!
Preview URL:	https://5749a93c.pydantic-docs.pages.dev
Branch Preview URL:	https://protected-ns.pydantic-docs.pages.dev

View logs

Viicos reviewed

Sep 18, 2024

View reviewed changes

docs/concepts/serialization.md OutdatedShow resolvedHide resolved

pydantic/_internal/_model_construction.py OutdatedShow resolvedHide resolved

docs/concepts/serialization.md OutdatedShow resolvedHide resolved

Copy link

codspeed-hqbot commentedSep 18, 2024•
edited
Loading

CodSpeed Performance Report

Merging#10441 willnot alter performance

_{Comparingprotected-ns (36a7816) withmain (296f2ca)}

Summary

✅ 38 untouched benchmarks

sydney-runkle force-pushed theprotected-ns branch 2 times, most recently from231eb93 toe9d3e43Compare

September 19, 2024 14:27

sydney-runkle added2 commits

September 19, 2024 10:42

changing default

a18bf94

changing tests, adding updatesremove added spaceUpdate docs/concepts/serialization.mdCo-authored-by: hyperlint-ai[bot] <154288675+hyperlint-ai[bot]@users.noreply.github.com>Update docs/concepts/serialization.mdCo-authored-by: Victorien <65306057+Viicos@users.noreply.github.com>removing warning related code

fixing test

0a9bfa9

removing unneeded warning check

sydney-runkle force-pushed theprotected-ns branch from1859a35 to0a9bfa9Compare

September 19, 2024 14:43

Copy link

Contributor

github-actionsbot commentedSep 19, 2024•
edited
Loading

Coverage report

This PR does not seem to contain any modification to coverable code.

sydney-runkle mentioned this pull request

Sep 19, 2024

pydantic work plan for Sydney Runkle, September 16th - 20th, 2024#10415

Closed

11 tasks

sydney-runkle requested a review fromsamuelcolvin

September 20, 2024 14:16

samuelcolvin reviewed

Sep 22, 2024

View reviewed changes

Copy link

Member

samuelcolvin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

one real question, otherwise LGTM.

pydantic/config.pyShow resolvedHide resolved

pydantic/_internal/_config.py OutdatedShow resolvedHide resolved

model_dump and model_validate without trailing underscore

b648b57

hyperlint-aibot reviewed

Sep 23, 2024

View reviewed changes

Copy link

Contributor

hyperlint-aibot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

1 files reviewed, 2 total issue(s) found.

blog.md OutdatedShow resolvedHide resolved

remove blog, oops

2b23d70

sydney-runkle requested a review fromsamuelcolvin

September 23, 2024 18:01

samuelcolvin reviewed

Sep 24, 2024

View reviewed changes

pydantic/config.py OutdatedShow resolvedHide resolved

sydney-runkle commented

Sep 24, 2024

View reviewed changes

pydantic/config.py OutdatedShow resolvedHide resolved

Update pydantic/config.py

e1c9a9c

elidlocke reviewed

Sep 25, 2024

View reviewed changes

pydantic/_internal/_config.pyShow resolvedHide resolved

sydney-runkleand others added4 commits

September 25, 2024 16:08

note about potential future support

af0a112

Merge branch 'main' into protected-ns

513ab9f

Merge branch 'main' into protected-ns

1788f1d

merge with pattern support

36a7816

Copy link

ContributorAuthor

sydney-runkle commentedOct 2, 2024•
edited
Loading

I think this should be ready for review. Given#10493, I actually don't think it's necessary that we addmodel_fields,model_extra, etc to theprotected_namespaces default:

frompydanticimportBaseModelfromtypingimportAnyclassUser(BaseModel):model_fields:list[str]model_computed_fields:list[str]model_extra:dict[str,Any]model_fields_set:set[str]user=User(model_fields=['id','name'],model_computed_fields=[],model_extra={},model_fields_set={'id','name'})"""/Users/programming/pydantic_work/pydantic/pydantic/_internal/_fields.py:190: UserWarning: Field name "model_fields" in "User" shadows an attribute in parent "BaseModel"  warnings.warn(/Users/programming/pydantic_work/pydantic/pydantic/_internal/_fields.py:190: UserWarning: Field name "model_computed_fields" in "User" shadows an attribute in parent "BaseModel"  warnings.warn(/Users/programming/pydantic_work/pydantic/pydantic/_internal/_fields.py:190: UserWarning: Field name "model_extra" in "User" shadows an attribute in parent "BaseModel"  warnings.warn(/Users/programming/pydantic_work/pydantic/pydantic/_internal/_fields.py:190: UserWarning: Field name "model_fields_set" in "User" shadows an attribute in parent "BaseModel"  warnings.warn("""

I've also enabled support for compiled patterns, though I don't think that's necessary, as all other overrides are methods - which are standard practice to override, and you'll get type checking warnings if signature isn't compatible or b) warnings if something conflicts with the protected namespaces.

Viicos reviewed

Oct 2, 2024

View reviewed changes

pydantic/_internal/_config.py

		@@ -273,7 +273,7 @@ def push(self, config_wrapper: ConfigWrapper \| ConfigDict \| None):
		ser_json_inf_nan='null',
		validate_default=False,
		validate_return=False,
		protected_namespaces=('model_',),
		protected_namespaces=('model_validate', 'model_dump'),

Copy link

Member

ViicosOct 2, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Do we also want to addmodel_construct here?

Copy link

ContributorAuthor

sydney-runkleOct 2, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Good question, cc@samuelcolvin @dmontagu

Copy link

ContributorAuthor

sydney-runkleOct 2, 2024•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Following up here - we decided we didn't need to addmodel_construct - that's not a namespace we anticipate expanding in the same way we do formodel_dump_ etc, you can imaginepython,json,some_other_format.