frompydanticimportBaseModelfrompydantic.v1importBaseModelasBaseModelV1classV1Model(BaseModelV1):    ...classV2Model(BaseModel):inner:V1Model"""UserWarning: Nesting V1 models inside V2 models is not supported. Please upgrade V1Model to V2."""

adding v1 / v2 incompatibility warning

5316632

sydney-runkle changed the title~~Adding v1 / v2 incompatibility warning for nested v1 model:~~Adding v1 / v2 incompatibility warning for nested v1 model

Sep 17, 2024

github-actionsbot added the relnotes-fixUsed for bugfixes. label

Sep 17, 2024

sydney-runkle added relnotes-feature and removed relnotes-fixUsed for bugfixes. labels

Sep 17, 2024

Copy link

cloudflare-workers-and-pagesbot commentedSep 17, 2024•
edited
Loading

Deploying pydantic-docs with Cloudflare Pages

Latest commit:	`8f9599f`
Status:	✅ Deploy successful!
Preview URL:	https://3c809738.pydantic-docs.pages.dev
Branch Preview URL:	https://incompat-warning.pydantic-docs.pages.dev

View logs

sydney-runkle requested a review fromViicos

September 17, 2024 15:39

Copy link

codspeed-hqbot commentedSep 17, 2024•
edited
Loading

CodSpeed Performance Report

Merging#10431 willnot alter performance

_{Comparingincompat-warning (8f9599f) withmain (59a3de7)}

Summary

✅ 49 untouched benchmarks

Copy link

Contributor

github-actionsbot commentedSep 17, 2024•
edited
Loading

Coverage report

Click to see where and how coverage changed

File	Statements	Missing	Coverage	Coverage (new stmts)	Lines missing
pydantic/_internal
_dataclasses.py
_model_construction.py
Project Total

_{This report was generated bypython-coverage-comment-action}

ticks

74c2ff1

sydney-runkle mentioned this pull request

Sep 17, 2024

pydantic work plan for Sydney Runkle, September 16th - 20th, 2024#10415

Closed

11 tasks

Viicos reviewed

Sep 17, 2024

View reviewed changes

pydantic/_internal/_generate_schema.pyShow resolvedHide resolved

pydantic/_internal/_generate_schema.py Outdated

Comment on lines 826 to 830

		if issubclass(obj, BaseModelV1):
		warn(
		f'Nesting V1 models inside V2 models is not supported. Please upgrade `{obj.__name__}` to V2.',
		UserWarning,
		)

Copy link

Member

ViicosSep 17, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

This will warn when doing the following:

frompydanticimportTypeAdapterfrompydantic.v1importBaseModelasBaseModelV1TypeAdapter(BaseModelV1)

So maybe there's a way to check for the current model stack before warning?

Copy link

ContributorAuthor

sydney-runkleSep 18, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Hmm, we don't supportTypeAdapter with v1 models anyways... so maybe I should just make the warning more broad?

Copy link

ContributorAuthor

sydney-runkleSep 18, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I've modified the warning accordingly

sydney-runkle added2 commits

September 18, 2024 09:47

change warning

5efeff1

modifying warning

8f9599f

sydney-runkle requested a review fromViicos

September 18, 2024 13:55

Viicos approved these changes

Sep 18, 2024

View reviewed changes

sydney-runkleenabled auto-merge (squash)

September 18, 2024 13:57

sydney-runkle merged commitfbfcc60 intomain

Sep 18, 2024

59 checks passed

sydney-runkle deleted the incompat-warning branch

September 18, 2024 14:08

Labels

relnotes-feature

2 participants

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Adding v1 / v2 incompatibility warning for nested v1 model#10431

Adding v1 / v2 incompatibility warning for nested v1 model#10431

Uh oh!