Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Fix rendering ofStringContraints example#10421

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

dlax
Copy link
Contributor

@dlaxdlax commentedSep 17, 2024•
edited
Loading

Change Summary

Fix rendering ofStringContraints example (https://docs.pydantic.dev/latest/api/types/#pydantic.types.StringConstraints)

Checklist

  • The pull request title is a good summary of the changes - it will be used in the changelog
  • Unit tests for the changes exist
  • Tests pass on CI
  • Documentation reflects the changes where applicable
  • My PR is ready to review,please add a comment including the phrase "please review" to assign reviewers

Selected Reviewer:@sydney-runkle

@github-actionsgithub-actionsbot added the relnotes-fixUsed for bugfixes. labelSep 17, 2024
@dlaxdlax marked this pull request as ready for reviewSeptember 17, 2024 07:06
@dlax
Copy link
ContributorAuthor

please review

pydantic-hooky[bot] reacted with thumbs up emoji

@codspeed-hqCodSpeed HQ
Copy link

CodSpeed Performance Report

Merging#10421 willnot alter performance

Comparingdlax:fix-stringcontraints-example-fmt (1bba9c4) withmain (2f4723f)

Summary

✅ 49 untouched benchmarks

Copy link
Member

@ViicosViicos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks for the fix. We should definitely improve our docs linting setup.

@ViicosViicos mentioned this pull requestSep 17, 2024
11 tasks
@github-actionsGitHub Actions
Copy link
Contributor

Coverage report

This PR does not seem to contain any modification to coverable code.

@ViicosViicos merged commitcf671c8 intopydantic:mainSep 17, 2024
60 checks passed
@dlaxdlax deleted the fix-stringcontraints-example-fmt branchSeptember 17, 2024 08:36
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@ViicosViicosViicos approved these changes

Assignees

@sydney-runklesydney-runkle

Labels
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@dlax@Viicos@sydney-runkle
[8]ページ先頭
©2009-2025 Movatter.jp