Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Add support for unpackedTypedDict to type hint variadic keyword arguments with@validate_call#10416

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
sydney-runkle merged 9 commits intomainfromkwargs-td
Sep 20, 2024

Conversation

Viicos
Copy link
Member

@ViicosViicos commentedSep 16, 2024•
edited
Loading

Change Summary

Fixes#9619
Requirespydantic/pydantic-core#1451

Related issue number

Checklist

  • The pull request title is a good summary of the changes - it will be used in the changelog
  • Unit tests for the changes exist
  • Tests pass on CI
  • Documentation reflects the changes where applicable
  • My PR is ready to review,please add a comment including the phrase "please review" to assign reviewers

@github-actionsgithub-actionsbot added the relnotes-fixUsed for bugfixes. labelSep 16, 2024
@cloudflare-workers-and-pagesCloudflare Workers and Pages
Copy link

cloudflare-workers-and-pagesbot commentedSep 16, 2024•
edited
Loading

Deploying pydantic-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit:068bdc9
Status: ✅  Deploy successful!
Preview URL:https://7313594d.pydantic-docs.pages.dev
Branch Preview URL:https://kwargs-td.pydantic-docs.pages.dev

View logs

@codspeed-hqCodSpeed HQ
Copy link

codspeed-hqbot commentedSep 16, 2024•
edited
Loading

CodSpeed Performance Report

Merging#10416 willnot alter performance

Comparingkwargs-td (068bdc9) withmain (9b69920)

Summary

✅ 38 untouched benchmarks

@ViicosViicos marked this pull request as ready for reviewSeptember 17, 2024 13:56
Copy link
Contributor

@sydney-runklesydney-runkle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM - let's add documentation to both the concepts and api sections of the docs.

Re API section - you can add this to the standard library types area.

@pydantic-hookypydantic-hookybot added awaiting author revisionawaiting changes from the PR author labelsSep 17, 2024
Copy link
Contributor

@hyperlint-aihyperlint-aibot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

1 files reviewed, 1 outstanding issue(s) found.

Copy link
Contributor

@sydney-runklesydney-runkle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Looks great, thanks! Thanks for adding a test for the override as well.

@sydney-runklesydney-runkleenabled auto-merge (squash)September 20, 2024 17:26
@sydney-runklesydney-runkle added relnotes-feature and removed awaiting author revisionawaiting changes from the PR author relnotes-fixUsed for bugfixes. labelsSep 20, 2024
@sydney-runkle
Copy link
Contributor

cc@Viicos, I don't think this was addressed:

LGTM - let's add documentation to both the concepts and api sections of the docs.

Going ahead and merging this now, but could you add docs for this next week?

@sydney-runklesydney-runkle merged commite301d4a intomainSep 20, 2024
61 checks passed
@sydney-runklesydney-runkle deleted the kwargs-td branchSeptember 20, 2024 17:52
@github-actionsGitHub Actions
Copy link
Contributor

Coverage report

This PR does not seem to contain any modification to coverable code.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@sydney-runklesydney-runklesydney-runkle approved these changes

@hyperlint-aihyperlint-ai[bot]hyperlint-ai[bot] left review comments

Assignees

@ViicosViicos

Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

typing.Unpack support: Unpack typed dict for keyword argument typing
2 participants
@Viicos@sydney-runkle
[8]ページ先頭
©2009-2025 Movatter.jp