Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Fix variance issue in_IncEx type alias, only allowTrue#10414

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
sydney-runkle merged 4 commits intomainfrominc-ex-ann-2
Sep 16, 2024

Conversation

Viicos
Copy link
Member

Change Summary

Fixes#10335
Requirespydantic/pydantic-core#1453

Related issue number

Checklist

  • The pull request title is a good summary of the changes - it will be used in the changelog
  • Unit tests for the changes exist
  • Tests pass on CI
  • Documentation reflects the changes where applicable
  • My PR is ready to review,please add a comment including the phrase "please review" to assign reviewers

@github-actionsgithub-actionsbot added the relnotes-fixUsed for bugfixes. labelSep 16, 2024
@cloudflare-workers-and-pagesCloudflare Workers and Pages
Copy link

cloudflare-workers-and-pagesbot commentedSep 16, 2024•
edited
Loading

Deploying pydantic-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit:dd81218
Status: ✅  Deploy successful!
Preview URL:https://18f5c34f.pydantic-docs.pages.dev
Branch Preview URL:https://inc-ex-ann-2.pydantic-docs.pages.dev

View logs

@codspeed-hqCodSpeed HQ
Copy link

codspeed-hqbot commentedSep 16, 2024•
edited
Loading

CodSpeed Performance Report

Merging#10414 willdegrade performances by 12.56%

Comparinginc-ex-ann-2 (dd81218) withmain (a764871)

Summary

❌ 2 (👁 2) regressions
✅ 47 untouched benchmarks

Benchmarks breakdown

Benchmarkmaininc-ex-ann-2Change
👁test_complex_model_serialization54 µs61.8 µs-12.56%
👁test_model_json_serialization57.9 µs66.1 µs-12.32%

@github-actionsGitHub Actions
Copy link
Contributor

github-actionsbot commentedSep 16, 2024•
edited
Loading

Coverage report

This PR does not seem to contain any modification to coverable code.

Copy link
Contributor

@sydney-runklesydney-runkle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Could you please add some info to the docs re the fact that we only supportTrue? Thanks!

@pydantic-hookypydantic-hookybot added the awaiting author revisionawaiting changes from the PR author labelSep 16, 2024
Copy link
Contributor

@sydney-runklesydney-runkle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM, pending test passes :)

@sydney-runklesydney-runkleenabled auto-merge (squash)September 16, 2024 16:41
@sydney-runklesydney-runkle merged commit2e38ec4 intomainSep 16, 2024
61 checks passed
@sydney-runklesydney-runkle deleted the inc-ex-ann-2 branchSeptember 16, 2024 16:57
sydney-runkle added a commit that referenced this pull requestSep 17, 2024
Co-authored-by: sydney-runkle <sydneymarierunkle@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@sydney-runklesydney-runklesydney-runkle approved these changes

Assignees

@ViicosViicos

Labels
awaiting author revisionawaiting changes from the PR authorrelnotes-fixUsed for bugfixes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

include/exclude doesn't work when usingFalse
2 participants
@Viicos@sydney-runkle
[8]ページ先頭
©2009-2025 Movatter.jp