NotificationsYou must be signed in to change notification settings
Fork2.2k
Star24.6k

Fix`PydanticUserError` on empty`model_config` with annotations#10412

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

Viicos merged 1 commit intopydantic:mainfromtinydantic:cdwilson/fix-issue-10411

Sep 15, 2024

Merged

Fix`PydanticUserError` on empty`model_config` with annotations#10412

Viicos merged 1 commit intopydantic:mainfromtinydantic:cdwilson/fix-issue-10411

Sep 15, 2024

Conversation

Copy link

Contributor

cdwilson commentedSep 15, 2024•
edited
Loading

Change Summary

Prevents aPydanticUserError from being raised whenmodel_config has type annotations (model_config: ConfigDict), but is also empty.

For example, this previously raised aPydanticUserError:

classModel(BaseModel):model_config:ConfigDict= {}

Related issue number

Fixes#10411

Checklist

The pull request title is a good summary of the changes - it will be used in the changelog
Unit tests for the changes exist
Tests pass on CI
Documentation reflects the changes where applicable
My PR is ready to review,please add a comment including the phrase "please review" to assign reviewers

Fix PydanticUserError on empty model_config with annotations

ec1a501

Prevents a `PydanticUserError` from being raised when `model_config` hastype annotations (`model_config: ConfigDict`), but is also empty.For example, this previously raised a `PydanticUserError`:class Model(BaseModel):    model_config: ConfigDict = {}Fixespydantic#10411