Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

FixZoneInfo with various invalid types#10408

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
sydney-runkle merged 3 commits intomainfromzoneinfo-fix
Sep 13, 2024
Merged

Conversation

sydney-runkle
Copy link
Contributor

@github-actionsgithub-actionsbot added the relnotes-fixUsed for bugfixes. labelSep 13, 2024
@cloudflare-workers-and-pagesCloudflare Workers and Pages
Copy link

cloudflare-workers-and-pagesbot commentedSep 13, 2024•
edited
Loading

Deploying pydantic-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit:4d0f885
Status: ✅  Deploy successful!
Preview URL:https://a24fe6ab.pydantic-docs.pages.dev
Branch Preview URL:https://zoneinfo-fix.pydantic-docs.pages.dev

View logs

@codspeed-hqCodSpeed HQ
Copy link

codspeed-hqbot commentedSep 13, 2024•
edited
Loading

CodSpeed Performance Report

Merging#10408 willnot alter performance

Comparingzoneinfo-fix (4d0f885) withmain (656481f)

Summary

✅ 49 untouched benchmarks



def test_zoneinfo_union() -> None:
ta = TypeAdapter(Union[zoneinfo.ZoneInfo, timezone], config=ConfigDict(arbitrary_types_allowed=True))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

What's the reason to havearbitrary_types_allowed here?

Copy link
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

We don't supporttimezone 😅

@github-actionsGitHub Actions
Copy link
Contributor

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)		Lines missing
  pydantic/_internal
  _generate_schema.py
Project Total 

This report was generated bypython-coverage-comment-action

@sydney-runklesydney-runkle merged commit7daa2cd intomainSep 13, 2024
61 checks passed
@sydney-runklesydney-runkle deleted the zoneinfo-fix branchSeptember 13, 2024 19:28
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@ViicosViicosViicos left review comments

@dmontagudmontagudmontagu approved these changes

Assignees
No one assigned
Labels
relnotes-fixUsed for bugfixes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Error when validating timezone / ZoneInfo union
3 participants
@sydney-runkle@dmontagu@Viicos
[8]ページ先頭
©2009-2025 Movatter.jp