The existing FilePath type does not accept sockets, as they fail thePath.is_file(self) check.
As such, I added a newSocketPath type and corresponding validator usingPath.is_socket(self).

Related issue number

fix#10376

Checklist

The pull request title is a good summary of the changes - it will be used in the changelog
Unit tests for the changes exist
Tests pass on CI
Documentation reflects the changes where applicable
My PR is ready to review,please add a comment including the phrase "please review" to assign reviewers

Selected Reviewer:@sydney-runkle

github-actionsbot added the relnotes-fixUsed for bugfixes. label

Sep 10, 2024

Copy link

codspeed-hqbot commentedSep 10, 2024•
edited
Loading

CodSpeed Performance Report

Merging#10378 willnot alter performance

_{Comparingtheunkn0wn1:user/theunkn0wn1/validate_socket (b874a82) withmain (7daa2cd)}

Summary

✅ 49 untouched benchmarks

Copy link

ContributorAuthor

theunkn0wn1 commentedSep 11, 2024

Test will need to be skipped on windows; as it doesn't have sockets to begin with.
Not sure why the tests are failing on mac.

Viicos reviewed

Sep 12, 2024

View reviewed changes

Copy link

Member

Viicos left a comment•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I'm wondering if we should do something like:

Edit: Seems like on Windows,is_socket returnsFalse, so maybe it's safe to not add these kind of conditions.

pydantic/types.pyShow resolvedHide resolved

Viicos changed the title~~Add a SocketPath type~~Add aSocketPath type

Sep 12, 2024

Copy link

Contributor

sydney-runkle commentedSep 12, 2024

Looking good though, happy to support this once we get tests passing, etc :).

Copy link

ContributorAuthor

theunkn0wn1 commentedSep 13, 2024

ok for the issue with the Mac tests - pytest seems to be configured wrong, the temporary paths its generating with its fixture exceed the maximum length of a socket name on that platform.
Only way i can see to fix that would be to change the pytest config to use a more sensible base directory.
the trouble? i don't have a mac to test with and don't know what a sensible base path for that platform is.
Can I ask for some pointers here?

Copy link

Member

Viicos commentedSep 13, 2024

ok for the issue with the Mac tests - pytest seems to be configured wrong, the temporary paths its generating with its fixture exceed the maximum length of a socket name on that platform.
Only way i can see to fix that would be to change the pytest config to use a more sensible base directory.
the trouble? i don't have a mac to test with and don't know what a sensible base path for that platform is.
Can I ask for some pointers here?

I'm ok only running the test on Linux. The goal isn't to test that creating sockets works, but to ensure thatvalidate_socket works as expected when encountering a socket path.