Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Fix nested type statement#10369

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
sydney-runkle merged 1 commit intopydantic:mainfromkc0506:fix-nested-type-stmt
Sep 10, 2024

Conversation

kc0506
Copy link
Contributor

@kc0506kc0506 commentedSep 10, 2024•
edited
Loading

Change Summary

Fix the following:

frompydanticimportBaseModelclassA(BaseModel):    typeInt=int# currently will throws an error because `TypeAliasType` is not in `default_ignored_types()`a:Int

See:https://docs.python.org/3/reference/simple_stmts.html#type

Related issue number

Checklist

  • The pull request title is a good summary of the changes - it will be used in the changelog
  • Unit tests for the changes exist
  • Tests pass on CI
  • Documentation reflects the changes where applicable
  • My PR is ready to review,please add a comment including the phrase "please review" to assign reviewers

@github-actionsgithub-actionsbot added the relnotes-fixUsed for bugfixes. labelSep 10, 2024
@codspeed-hqCodSpeed HQ
Copy link

CodSpeed Performance Report

Merging#10369 willnot alter performance

Comparingkc0506:fix-nested-type-stmt (f980f0d) withmain (3bd7434)

Summary

✅ 49 untouched benchmarks

@github-actionsGitHub Actions
Copy link
Contributor

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)		Lines missing
  pydantic/_internal
  _model_construction.py
Project Total 

This report was generated bypython-coverage-comment-action

Copy link
Contributor

@sydney-runklesydney-runkle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Great! Contributing to#9782 :)

@sydney-runklesydney-runkle merged commit8138311 intopydantic:mainSep 10, 2024
60 checks passed
@kc0506kc0506 deleted the fix-nested-type-stmt branchOctober 14, 2024 10:05
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@sydney-runklesydney-runklesydney-runkle approved these changes

Assignees
No one assigned
Labels
relnotes-fixUsed for bugfixes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@kc0506@sydney-runkle
[8]ページ先頭
©2009-2025 Movatter.jp