Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Simplify unions involvingAny orNever when replacing type variables#10338

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
sydney-runkle merged 1 commit intomainfromsimplify-any-never-unions
Sep 10, 2024

Conversation

Viicos
Copy link
Member

Change Summary

I could have implemented this simplification for all cases (perhaps inGenerateSchema._apply_single_annotation or similar) but I don't want to break any unusual scenarios, plus this kind of situation is pretty uncommon in the general case (you're not really going to annotate a field asAny | <other>), it only makes sense when parameterizingT | <other> withAny/Never.

This has the added benefit of creating simplified JSON Schemas, as shown in the test.

Related issue number

Checklist

  • The pull request title is a good summary of the changes - it will be used in the changelog
  • Unit tests for the changes exist
  • Tests pass on CI
  • Documentation reflects the changes where applicable
  • My PR is ready to review,please add a comment including the phrase "please review" to assign reviewers

@github-actionsgithub-actionsbot added the relnotes-fixUsed for bugfixes. labelSep 6, 2024
@ViicosViicosforce-pushed thesimplify-any-never-unions branch fromf4d6be3 to9097bd2CompareSeptember 6, 2024 12:26
@cloudflare-workers-and-pagesCloudflare Workers and Pages
Copy link

cloudflare-workers-and-pagesbot commentedSep 6, 2024•
edited
Loading

Deploying pydantic-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit:9097bd2
Status: ✅  Deploy successful!
Preview URL:https://fcd106ae.pydantic-docs.pages.dev
Branch Preview URL:https://simplify-any-never-unions.pydantic-docs.pages.dev

View logs

@codspeed-hqCodSpeed HQ
Copy link

codspeed-hqbot commentedSep 6, 2024•
edited
Loading

CodSpeed Performance Report

Merging#10338 willnot alter performance

Comparingsimplify-any-never-unions (9097bd2) withmain (c452c7e)

Summary

✅ 49 untouched benchmarks

@github-actionsGitHub Actions
Copy link
Contributor

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)		Lines missing
  pydantic/_internal
  _generics.py
Project Total 

This report was generated bypython-coverage-comment-action

Copy link
Contributor

@sydney-runklesydney-runkle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Awesome! Thanks for the inline comments, makes this super easy to review / understand for future devs.

@sydney-runklesydney-runkle merged commit287c266 intomainSep 10, 2024
61 checks passed
@sydney-runklesydney-runkle deleted the simplify-any-never-unions branchSeptember 10, 2024 16:38
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@sydney-runklesydney-runklesydney-runkle approved these changes

Assignees
No one assigned
Labels
relnotes-fixUsed for bugfixes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@Viicos@sydney-runkle
[8]ページ先頭
©2009-2025 Movatter.jp