Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Use correct types namespace when building namedtuple core schemas#10337

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
sydney-runkle merged 2 commits intomainfrom10336
Sep 6, 2024

Conversation

Viicos
Copy link
Member

@ViicosViicos commentedSep 6, 2024•
edited
Loading

Change Summary

Fixes#10336

Regression introduced in#10063

See diffwithout whitespaces

Related issue number

Checklist

  • The pull request title is a good summary of the changes - it will be used in the changelog
  • Unit tests for the changes exist
  • Tests pass on CI
  • Documentation reflects the changes where applicable
  • My PR is ready to review,please add a comment including the phrase "please review" to assign reviewers

@github-actionsgithub-actionsbot added the relnotes-fixUsed for bugfixes. labelSep 6, 2024
@cloudflare-workers-and-pagesCloudflare Workers and Pages
Copy link

cloudflare-workers-and-pagesbot commentedSep 6, 2024•
edited
Loading

Deploying pydantic-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit:61ef3dd
Status: ✅  Deploy successful!
Preview URL:https://801cbc02.pydantic-docs.pages.dev
Branch Preview URL:https://10336.pydantic-docs.pages.dev

View logs

@codspeed-hqCodSpeed HQ
Copy link

codspeed-hqbot commentedSep 6, 2024•
edited
Loading

CodSpeed Performance Report

Merging#10337 willnot alter performance

Comparing10336 (61ef3dd) withmain (97d357f)

Summary

✅ 50 untouched benchmarks

Copy link
Contributor

@sydney-runklesydney-runkle left a comment•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Great find@Viicos. Do we need to make any changed to typed dicts (I see we also changed that schema gen func in the original PR)

Feel free to remove that benchmark for now (let's comment it out), it's too flaky to be valuable at this point.

@github-actionsGitHub Actions
Copy link
Contributor

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)		Lines missing
  pydantic/_internal
  _generate_schema.py
Project Total 

This report was generated bypython-coverage-comment-action

@Viicos
Copy link
MemberAuthor

Do we need to make any changed to typed dicts

The types namespace stack is updated for typeddicts but wasn't for namedtuples, so this only affected the latter.

sydney-runkle reacted with thumbs up emoji

@Viicos
Copy link
MemberAuthor

Feel free to remove that benchmark for now (let's comment it out), it's too flaky to be valuable at this point.

I have a pending PR that I'll finish this afternoon to tackle this

@sydney-runkle
Copy link
Contributor

Sounds good. Also, could you please add a test before we merge?

Copy link
Contributor

@sydney-runklesydney-runkle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Great work!

@sydney-runklesydney-runkle merged commitc452c7e intomainSep 6, 2024
61 checks passed
@sydney-runklesydney-runkle deleted the 10336 branchSeptember 6, 2024 12:04
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@sydney-runklesydney-runklesydney-runkle approved these changes

Assignees
No one assigned
Labels
relnotes-fixUsed for bugfixes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Wrong class namespace used when evaluating annotations of aNamedTuple
2 participants
@Viicos@sydney-runkle
[8]ページ先頭
©2009-2025 Movatter.jp