Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork2.2k
Turntzdata install requirement into optionaltimezone dependency#10331
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Uh oh!
There was an error while loading.Please reload this page.
codspeed-hqbot commentedSep 5, 2024 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
CodSpeed Performance ReportMerging#10331 willnot alter performanceComparing Summary
|
Coverage reportThis PR does not seem to contain any modification to coverable code. |
@sydney-runkle: Please have a look. Thank you! |
sydney-runkle approved these changesSep 6, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Great, thanks for the quick turnaround!
97d357f intopydantic:main 60 checks passed
Uh oh!
There was an error while loading.Please reload this page.
hswong3i pushed a commit to alvistack/pydantic-pydantic that referenced this pull requestSep 6, 2024
git clean -xdf tar zcvf ../python-pydantic_2.9.0.orig.tar.gz --exclude=.git . debuild -uc -us cp python-pydantic.spec ../python-pydantic_2.9.0-1.spec cp ../python*-pydantic*2.9.0*.{gz,xz,spec,dsc} /osc/home\:alvistack/pydantic-pydantic-2.9.0/ rm -rf ../python*-pydantic*2.9.0*.*Seepydantic#10331Signed-off-by: Wong Hoi Sing Edison <hswong3i@pantarei-design.com>sydney-runkle pushed a commit that referenced this pull requestSep 9, 2024
hswong3i pushed a commit to alvistack/pydantic-pydantic that referenced this pull requestSep 9, 2024
git clean -xdf tar zcvf ../python-pydantic_2.9.1.orig.tar.gz --exclude=.git . debuild -uc -us cp python-pydantic.spec ../python-pydantic_2.9.1-1.spec cp ../python*-pydantic*2.9.1*.{gz,xz,spec,dsc} /osc/home\:alvistack/pydantic-pydantic-2.9.1/ rm -rf ../python*-pydantic*2.9.1*.*Seepydantic#10331Signed-off-by: Wong Hoi Sing Edison <hswong3i@pantarei-design.com>arnout pushed a commit to buildroot/buildroot that referenced this pull requestSep 9, 2024
pyproject.toml declared the tzdata package as a required dependency, butthis is in fact only needed on win32. This was fixed upstream [1]. Sincewe don't actually check the runtime dependencies from pyproject.toml, wedon't need to do anything in Buildroot.[1]pydantic/pydantic#10331Signed-off-by: James Hilliard <james.hilliard1@gmail.com>[Arnout: remove tzdata runtime dependency]Signed-off-by: Arnout Vandecappelle <arnout@mind.be>
hswong3i pushed a commit to alvistack/pydantic-pydantic that referenced this pull requestSep 18, 2024
git clean -xdf tar zcvf ../python-pydantic_2.9.2.orig.tar.gz --exclude=.git . debuild -uc -us cp python-pydantic.spec ../python-pydantic_2.9.2-1.spec cp ../python*-pydantic*2.9.2*.{gz,xz,spec,dsc} /osc/home\:alvistack/pydantic-pydantic-2.9.2/ rm -rf ../python*-pydantic*2.9.2*.*Seepydantic#10331Signed-off-by: Wong Hoi Sing Edison <hswong3i@pantarei-design.com>hswong3i pushed a commit to alvistack/pydantic-pydantic that referenced this pull requestNov 14, 2024
git clean -xdf tar zcvf ../python-pydantic_2.9.2.orig.tar.gz --exclude=.git . debuild -uc -us cp python-pydantic.spec ../python-pydantic_2.9.2-1.spec cp ../python*-pydantic*2.9.2*.{gz,xz,spec,dsc} /osc/home\:alvistack/pydantic-pydantic-2.9.2/ rm -rf ../python*-pydantic*2.9.2*.*Seepydantic#10331Signed-off-by: Wong Hoi Sing Edison <hswong3i@pantarei-design.com>sfoster1 pushed a commit to Opentrons/buildroot that referenced this pull requestDec 6, 2024
pyproject.toml declared the tzdata package as a required dependency, butthis is in fact only needed on win32. This was fixed upstream [1]. Sincewe don't actually check the runtime dependencies from pyproject.toml, wedon't need to do anything in Buildroot.[1]pydantic/pydantic#10331Signed-off-by: James Hilliard <james.hilliard1@gmail.com>[Arnout: remove tzdata runtime dependency]Signed-off-by: Arnout Vandecappelle <arnout@mind.be>
sfoster1 pushed a commit to Opentrons/buildroot that referenced this pull requestDec 9, 2024
pyproject.toml declared the tzdata package as a required dependency, butthis is in fact only needed on win32. This was fixed upstream [1]. Sincewe don't actually check the runtime dependencies from pyproject.toml, wedon't need to do anything in Buildroot.[1]pydantic/pydantic#10331Signed-off-by: James Hilliard <james.hilliard1@gmail.com>[Arnout: remove tzdata runtime dependency]Signed-off-by: Arnout Vandecappelle <arnout@mind.be>
sfoster1 pushed a commit to Opentrons/buildroot that referenced this pull requestDec 18, 2024
pyproject.toml declared the tzdata package as a required dependency, butthis is in fact only needed on win32. This was fixed upstream [1]. Sincewe don't actually check the runtime dependencies from pyproject.toml, wedon't need to do anything in Buildroot.[1]pydantic/pydantic#10331Signed-off-by: James Hilliard <james.hilliard1@gmail.com>[Arnout: remove tzdata runtime dependency]Signed-off-by: Arnout Vandecappelle <arnout@mind.be>
1 task
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
Change Summary
#9896 adds an install requirement for
tzdata, which states:Non-Windows system typically have time zone data installed and do not need
tzdata. This PR turns thetzdatadependency into an optional dependency grouptimezone. Documentation is updated accordingly.Related issue number
fix#10328
Checklist