Deploying pydantic-docs with    Cloudflare Pages

View logs

CodSpeed Performance Report

Merging#10313 willnot alter performance

_{Comparingdc-defer-build (7ae6da8) withmain (59a3de7)}

Summary

✅ 49 untouched benchmarks

Coverage report

Click to see where and how coverage changed

File	Statements	Missing	Coverage	Coverage (new stmts)	Lines missing
pydantic
dataclasses.py
pydantic/_internal
_dataclasses.py
_model_construction.py
Project Total

This report was generated bypython-coverage-comment-action

So the reason why the added_force_build argument was required is because currently ultimately,rebuild_dataclass callscomplete_dataclass. Because the configuration can come from both the decorator or the__pydantic_config__ attribute,complete_dataclass setscls.__pydantic_config__:

So that the following works as expected:

@pydantic_dataclass(config={'strict':True})classDC:a:intassertDC.__pydantic_config__== {'strict':True}

If inrebuild_dataclass, we pass a new config object, as done currently here:

The following will happen:

@pydantic_dataclassclassDC:__pydantic_config__= {'defer_build':True}# or as a decorator parameter, doesn't matterassertDC.__pydantic_config__== {'defer_build':True}rebuild_dataclass(DC)assertDC.__pydantic_config__== {'defer_build':True}# AssertionError, `'defer_build'` is now set to `False`

And is inconsistent with theBaseModel behavior. Besides, I think the config dict on models and dataclasses shouldn't change after the class is defined, no matter if a rebuild was performed or not (and this is what's causing issues withTypeAdapter failing tests I think).

And is inconsistent with the BaseModel behavior. Besides, I think the config dict on models and dataclasses shouldn't change after the class is defined, no matter if a rebuild was performed or not (and this is what's causing issues with TypeAdapter failing tests I think).

I see, makes sense. Let's revert back then to use the_force_build flag. Apologies for the back and forth on the diff.