Commit568509c

and

authored

MakeSecret covariant (#12008)

Co-authored-by: Victorien <65306057+Viicos@users.noreply.github.com>

1 parentc6d9446 commit568509cCopy full SHA for 568509c

File tree

+11

-1

lines changed

+11

-1

lines changed

Lines changed: 2 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -1530,7 +1530,8 @@ def __eq__(self, other: Any) -> bool:`
`1530`	`1530`
`1531`	`1531`	`# ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ SECRET TYPES ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~`
`1532`	`1532`
`1533`		`-SecretType=TypeVar('SecretType')`
	`1533`	+# The `Secret` class being conceptually immutable, make the type variable covariant:
	`1534`	`+SecretType=TypeVar('SecretType',covariant=True)`
`1534`	`1535`
`1535`	`1536`
`1536`	`1537`	`class_SecretBase(Generic[SecretType]):`

Lines changed: 9 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1,9 @@`
	`1`	`+frompydanticimportSecret`
	`2`	`+`
	`3`	`+`
	`4`	`+deftakes_secret(scalar_secret:Secret[str\|int\|float\|bool])->None: ...`
	`5`	`+`
	`6`	`+`
	`7`	`+defsecret_usage()->None:`
	`8`	`+secret:Secret[str]=Secret('my secret')`
	`9`	`+takes_secret(secret)`

Comments

(0)