- Notifications
You must be signed in to change notification settings - Fork134
allowLOGFIRE_BASE_URL
to acceptgrpc
endpoints#1048
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:main
Are you sure you want to change the base?
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Uh oh!
There was an error while loading.Please reload this page.
cloudflare-workers-and-pagesbot commentedApr 30, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Deploying logfire-docs with |
Latest commit: | 25d335a |
Status: | ✅ Deploy successful! |
Preview URL: | https://a37bb325.logfire-docs.pages.dev |
Branch Preview URL: | https://dh-grpc.logfire-docs.pages.dev |
self.token = credentials.token | ||
self.advanced.base_url = self.advanced.base_url or credentials.logfire_api_url | ||
except LogfireConfigError: | ||
if self.advanced.base_url is not None: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I think we should only allow this if it is a grpc url?
Alternatively, perhaps we could split the logic, and have different code paths depending on whether the endpoint is HTTP/gRPC
Related to#1042
The idea (from offline discussion) is that we can set
LOGFIRE_BASE_URL
to a grpc endpoint and everything can "just work", with the caveat that we wouldn't be able to do any token checking.This is sufficient for a local test script to work for me:
Steps to complete before merge: