forked fromapache/arrow-rs
- Notifications
You must be signed in to change notification settings - Fork0
With json get mut#4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Draft
cetra3 wants to merge2 commits intomasterChoose a base branch fromwith_json_get_mut
base:master
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Draft
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
…yarrow` and `parquet-variant` (apache#7745)Note this targets a release branch, not mainI have a different proposed fix for `main`:-apache#7742I will also make a fix for parquet-variant test failures# Which issue does this PR close?- Related toapache#7394- Related toapache#7736- Related toapache#7746# Rationale for this change`cargo test --all` requires python and pyarrow installed, where it didnot in previous versions of arrow due to breaking out `arrow-pyarrow`into its own crate in-apache#7694Also the new `parquet-variant` crate tests fail as part of theverification script too -- seettps://github.com/apache/issues/7746In order to get a script that can automatically verify a releasecandidate, let's ignore this new module for now.More details -apache#7736 -apache#7742Note that the arrow-pyarrow tests do run as part of CI and succeed onthis branch# What changes are included in this PR?1. Exclude running the `arrow-pyarrow` and `parquet-variant` tests aspart of `verify-release-acndidate`# TestingI verified locally that `./dev/release/verify-release-candidate.sh55.2.0 1` passes with this script# Are there any user-facing changes?No this is a development process only change
# Which issue does this PR close?None# Rationale for this changeI need access to the writer so that I can flush an external buffer whenbytes are written.# What changes are included in this PR?A couple of methods to the JSON writer. These methods already exist onother writers# Are these changes tested?N/A# Are there any user-facing changes?Yes, a couple extra methods on the JSON writer.---------Co-authored-by: Andrew Lamb <andrew@nerdnetworks.org>
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is just
55.2.0
withapache#7854 as well