NotificationsYou must be signed in to change notification settings
Fork2.2k
Star16.4k

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

[WIP] Remove ruff ignore E501#5539

Draft

rwgk wants to merge1 commit intopybind:master

base:master

Choose a base branch

fromrwgk:remove_ruff_ignore_E501

Draft

[WIP] Remove ruff ignore E501#5539

rwgk wants to merge1 commit intopybind:masterfromrwgk:remove_ruff_ignore_E501

Conversation

Copy link

Collaborator

Description

With PR#4912 we removed black:

-# Black, the code formatter, natively supports pre-commit-- repo: https://github.com/psf/black-pre-commit-mirror-  rev: "23.10.1" # Keep in sync with blacken-docs-  hooks:-  - id: black

So this isn't true anymore:

pybind11/pyproject.toml

Line 72 ind8565ac

"E501",# Line too long (Black is enough)

I tried to remove that line, but it doesn't make a difference, ruff doesn't produce theE501 error. See dummy test case, which doesn't trigger any ruff errors.

It would be nice to see that error, even if we need to fix manually.

@henryiii: Do you happen to know what suppresses theE501?

Suggested changelog entry:

Remove ruff ignore E501, add dummy test case.

7b209be

Copy link

Contributor

As far as I can see, Ruff does not includeE501 by default, so it has to be added toextend-select.
Seedocs.astral.sh/ruff/configuration for the default settings:
Only"E4", "E7", "E9" are inselect but notE5.