- Notifications
You must be signed in to change notification settings - Fork1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
DEV: Remove ignore Ruff rule UP031#3205
Conversation
UP031: Use format specifiers instead of percent format.
UP031: Use format specifiers instead of percent format.
UP031: Use format specifiers instead of percent format.
UP031: Use format specifiers instead of percent format.
UP031: Use format specifiers instead of percent format.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@## main #3205 +/- ##==========================================- Coverage 96.54% 96.53% -0.01%========================================== Files 53 53 Lines 8935 8930 -5 Branches 1642 1642 ==========================================- Hits 8626 8621 -5 Misses 186 186 Partials 123 123 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
I have updated these without using the |
We should be able to get rid of the strings for both of the files using the representation completely as the message does not seem to really provide any benefit withpytest and its assertion rewriting. Or am I am missing something? |
UP031: Use format specifiers instead of percent format.
UP031: Use format specifiers instead of percent format.
Have amended so that this PR recreates completely what the existing code does (hopefully). I think you are saying that pytest gives us the same information implicitly, so the strings can be removed completely? Could keep this PR self-contained and then do other changes subsequently? |
Yes. |
UP031: Use format specifiers instead of percent format.
UP031: Use format specifiers instead of percent format.
Implemented, and the PR is still self-contained. |
UP031: Use format specifiers instead of percent format.