Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

DEV: Remove ignore Ruff rule UP031#3205

Merged
stefan6419846 merged 11 commits intopy-pdf:mainfromj-t-1:UP031
Mar 21, 2025
Merged

Conversation

j-t-1
Copy link
Contributor

UP031: Use format specifiers instead of percent format.

UP031: Use format specifiers instead of percent format.
UP031: Use format specifiers instead of percent format.
UP031: Use format specifiers instead of percent format.
UP031: Use format specifiers instead of percent format.
UP031: Use format specifiers instead of percent format.
@codecovCodecov
Copy link

codecovbot commentedMar 21, 2025
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.53%. Comparing base(524b37c) to head(2828e06).
Report is 8 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@##             main    #3205      +/-   ##==========================================- Coverage   96.54%   96.53%   -0.01%==========================================  Files          53       53                Lines        8935     8930       -5       Branches     1642     1642              ==========================================- Hits         8626     8621       -5  Misses        186      186                Partials      123      123

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report?Share it here.

🚀 New features to boost your workflow:
  • ❄️Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@j-t-1
Copy link
ContributorAuthor

I have updated these without using therepr version of f-string? Will update...

@stefan6419846
Copy link
Collaborator

We should be able to get rid of the strings for both of the files using the representation completely as the message does not seem to really provide any benefit withpytest and its assertion rewriting. Or am I am missing something?

UP031: Use format specifiers instead of percent format.
UP031: Use format specifiers instead of percent format.
@j-t-1
Copy link
ContributorAuthor

Have amended so that this PR recreates completely what the existing code does (hopefully).

I think you are saying that pytest gives us the same information implicitly, so the strings can be removed completely?

Could keep this PR self-contained and then do other changes subsequently?

@stefan6419846
Copy link
Collaborator

I think you are saying that pytest gives us the same information implicitly, so the strings can be removed completely?

Yes.

UP031: Use format specifiers instead of percent format.
UP031: Use format specifiers instead of percent format.
@j-t-1
Copy link
ContributorAuthor

I think you are saying that pytest gives us the same information implicitly, so the strings can be removed completely?

Yes.

Implemented, and the PR is still self-contained.

@stefan6419846stefan6419846 merged commit76e4ed1 intopy-pdf:mainMar 21, 2025
16 checks passed
@j-t-1j-t-1 deleted the UP031 branchMarch 21, 2025 15:32
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@stefan6419846stefan6419846stefan6419846 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@j-t-1@stefan6419846

[8]ページ先頭

©2009-2025 Movatter.jp