Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Add startsWith and endsWith#147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
triallax wants to merge8 commits intopurescript:master
base:master
Choose a base branch
Loading
fromtriallax:add-starts-with-and-ends-with

Conversation

@triallax
Copy link
Contributor

@triallaxtriallax commentedMar 10, 2021•
edited
Loading

Description of the change

AddstartsWith andendsWith functions toData.String.CodeUnits.

Fixes#127.

I know that there's still a bit of disagreement over whether this should be done or not, but I just opened this PR because it didn't take a lot of time. If it's ultimately decided against, feel free to close this PR.

To do:

  • suggeststripPrefix andstripSuffix
  • don't use FFI functions, instead usestripPrefix andstripSuffix
  • add functions toData.String.NonEmpty

Checklist:

  • Added the change to the changelog's "Unreleased" section with a reference to this PR (e.g. "- Made a change (#0000)")
  • Linked any existing issues or proposals that this pull request should close
  • Updated or added relevant documentation
  • Added a test for the contribution (if applicable)

@triallaxtriallax marked this pull request as ready for reviewApril 11, 2021 12:58
@triallaxtriallax marked this pull request as draftMay 10, 2021 18:33
This is because like `stripPrefix` and `stripSuffix`, these functionsare CodeUnit/CodePoint-agnostic. The same was also done for tests.
@triallaxtriallax marked this pull request as ready for reviewJuly 3, 2021 19:09
@Hi-Angel
Copy link

Hi-Angel commentedFeb 21, 2025•
edited
Loading

Please, don't fix older commits in newer ones

Screenshot_20250221_123931

A problem introduced by commit X should be fixed in commit X, otherwise reviewing the code becomes very hard, as well as reading the git history after this gets merged.

See alsothis post from Linux HID subsystem and libinput maintainer Peter Hutterer. Despite the post age it's well relevant today, "old but gold".

@triallax
Copy link
ContributorAuthor

@Hi-Angel thanks for the advice, but i'm not interested in purescript anymore (i haven't used it in years), feel free to take this up if you'd like

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add startsWith and endsWith

2 participants

@triallax@Hi-Angel
[8]ページ先頭
©2009-2025 Movatter.jp