Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Include type declaration SourceAnn for values#4471

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Draft
purefunctor wants to merge1 commit intomaster
base:master
Choose a base branch
Loading
frompure/type-value-decl

Conversation

purefunctor
Copy link
Member

Description of the change

This allows the compiler to be more honest about the source annotation for value declarations. During desugaring, theSourceAnn for a value declaration is replaced with a corresponding type declaration'sSourceAnn if it exists.

I noticed this while working on#4247 and it messes up the order for constructing the interval tree
which I intend to serialize into a file/use inpsc-ide as part of the type-on-hover stuff.

Another solution for this is to expand the annotation during desugaring such that both the annotation and value declaration is covered, but this changes behaviour in error messages.


Checklist:

  • Added a file to CHANGELOG.d for this PR (see CHANGELOG.d/README.md)
  • Added myself to CONTRIBUTORS.md (if this is my first contribution)
  • Linked any existing issues or proposals that this pull request should close
  • Updated or added relevant documentation
  • Added a test for the contribution (if applicable)

@purefunctorpurefunctor marked this pull request as draftApril 30, 2023 14:12
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

1 participant
@purefunctor

[8]ページ先頭

©2009-2025 Movatter.jp