Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Initial OTELp support#20585

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Draft
iwahbe wants to merge1 commit intomaster
base:master
Choose a base branch
Loading
fromiwahbe/otel
Draft

Initial OTELp support#20585

iwahbe wants to merge1 commit intomasterfromiwahbe/otel

Conversation

iwahbe
Copy link
Member

@iwahbeiwahbe commentedSep 25, 2025
edited
Loading

Switch the CLI over to usingOTEL.

TODO

  • Initialize the OTEL tracer
  • Add a HTTP backend compatible with a local Jaeger instance
  • Add a file backend for replay (there is afile exporter in development - it might work).
    • I think this is necessary so users can submit their traces to us.
  • Add the ability for the CLI to replay an exported OTEL file back.
  • Convert existing open tracing to OTEL
  • Update official and developer documentation on tracing
  • Since this will replace the existing--tracing implementation, it needs a changelog entry.

@tgummerer
Copy link
Collaborator

* [ ]  Add a file backend for replay (there is a [file exporter](https://pkg.go.dev/github.com/open-telemetry/opentelemetry-collector-contrib/exporter/fileexporter#FileExporter) in development - it might work).

When I looked at this, it looked tricky to do, as you'll need to collect traces from sub-processes as well. I didn't see the package you're linking though, so maybe it's possible. The best I had come up with is to maybe run a collector in the main CLI and have all plugins connect back to that to send traces.

  * I think this is necessary so users can submit their traces to us.

Jaeger does have a "export to JSON" option, which might be workable. It's obviously not as nice as just writing to a file directly, but might be okay if it makes things easier.

* [ ]  Convert existing open tracing to OTEL

We might want to support both for a while, since users might be using older providers which only support opentracing. It's also a breaking change to remove--tracing. Even though it's unlikely that anyone is using it in an automated way, we should still be careful about it.

@iwahbe
Copy link
MemberAuthor

* [ ]  Add a file backend for replay (there is a [file exporter](https://pkg.go.dev/github.com/open-telemetry/opentelemetry-collector-contrib/exporter/fileexporter#FileExporter) in development - it might work).

When I looked at this, it looked tricky to do, as you'll need to collect traces from sub-processes as well. I didn't see the package you're linking though, so maybe it's possible. The best I had come up with is to maybe run a collector in the main CLI and have all plugins connect back to that to send traces.

We might still need to do that. I think this package is more about a stable file format. We will still need to figure out how to pass a server address down to language hosts (and ultimately providers).

  * I think this is necessary so users can submit their traces to us.

Jaeger does have a "export to JSON" option, which might be workable. It's obviously not as nice as just writing to a file directly, but might be okay if it makes things easier.

I saw that. I'm really hoping it won't be necessary, but let's see. 😄

* [ ]  Convert existing open tracing to OTEL

We might want to support both for a while, since users might be using older providers which only support opentracing. It's also a breaking change to remove--tracing. Even though it's unlikely that anyone is using it in an automated way, we should still be careful about it.

I'm of 2 minds here. Removing the--tracing flag would be breaking, but if we convert our existing spans to OTEL then--tracing will start emitting empty traces. Maintaining full backwards compatibility by back-porting OTEL traces to opentracing seems like more effort then its worth.

We could start by adding an--otel flag and deprecating--tracing (as in your PR).

@tgummerer
Copy link
Collaborator

We could start by adding an--otel flag and deprecating--tracing (as in your PR).

Yeah I think that's the way to go. Imo we should just keep--tracing as it is, still emitting opentracing traces, essentially not changing anyting yet other than deprecating it, and add a--otel flag that is just additive.

@iwahbe
Copy link
MemberAuthor

We could start by adding an--otel flag and deprecating--tracing (as in your PR).

Yeah I think that's the way to go. Imo we should just keep--tracing as it is, still emitting opentracing traces, essentially not changing anyting yet other than deprecating it, and add a--otel flag that is just additive.

The issue there is how traces are emitted from our CLI code. If I want to add a new span to a function and I use OTEL to do so, then it won't show up in the opentracing output. Keeping--tracing long term means that we can never switch our tracing code to emit OTEL spans / metrics / logs. AFAIK we can bridged opentracing into OTEL, but not vice versa.

@tgummerer
Copy link
Collaborator

If I want to add a new span to a function and I use OTEL to do so, then it won't show up in the opentracing output.

Sure that's fine, we don't need anynew stuff to show up inopentracing, just preserve what we have until now. I also don't think we should support--tracing long term, but it should work through a deprecation period long enough to give everyone (including providers) to move over to otel.

iwahbe reacted with thumbs up emoji

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

@iwahbeiwahbe

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@iwahbe@tgummerer

[8]ページ先頭

©2009-2025 Movatter.jp