- Notifications
You must be signed in to change notification settings - Fork426
feat: upgrade React to v16.6.3#225
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Open
aleclarson wants to merge13 commits intoptmt:masterChoose a base branch
base:master
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Open
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Will be able to try to test on couple apps later this week …On Tue, 29 Jan 2019 at 07:15, Alec Larson ***@***.***> wrote: This PR provides support for the React version used by React Native v0.58.3 (the current version at time of writing). I've done some thorough testing in the RNTester, but it would be great if some other people could test this PR on their own apps and provide feedback. *Note:* This PR does *not* include any new *native* features, so there are plenty of react-native commits that still need to be ported over. I plan to make React hooks <https://reactjs.org/docs/hooks-intro.html> work inside react-native-macos in a future PR, so that's why this PR was created. ------------------------------ You can view, comment on, or merge this pull request online at:#225 Commit Summary - feat: upgrade React to v16.6.3 - Log query name for fetchRelayQuery - RN: Remove React Stack Systrace Logic - Move TouchHistoryMath from React Repo to React Native - Move takeSnapshot from React repo to RN - fix: delete ReactNativePropRegistry - fix: stop using ReactNativeComponentTree - fix: stop using ReactNativeBridgeEventPlugin - throw when <View> exists in <Text> - fix: remove unused Renderer shims - fix: add @providesModule to updated Renderer shims File Changes - *M* Libraries/Components/ScrollResponder.js <https://github.com/ptmt/react-native-macos/pull/225/files#diff-0> (15) - *M* Libraries/Components/View/View.js <https://github.com/ptmt/react-native-macos/pull/225/files#diff-1> (4) - *M* Libraries/Core/InitializeCore.js <https://github.com/ptmt/react-native-macos/pull/225/files#diff-2> (2) - *M* Libraries/Interaction/PanResponder.js <https://github.com/ptmt/react-native-macos/pull/225/files#diff-3> (2) - *A* Libraries/Interaction/TouchHistoryMath.js <https://github.com/ptmt/react-native-macos/pull/225/files#diff-4> (151) - *M* Libraries/Performance/Systrace.js <https://github.com/ptmt/react-native-macos/pull/225/files#diff-5> (64) - *M* Libraries/ReactNative/requireNativeComponent.js <https://github.com/ptmt/react-native-macos/pull/225/files#diff-6> (6) - *A* Libraries/ReactNative/takeSnapshot.js <https://github.com/ptmt/react-native-macos/pull/225/files#diff-7> (48) - *M* Libraries/Renderer/REVISION <https://github.com/ptmt/react-native-macos/pull/225/files#diff-8> (2) - *D* Libraries/Renderer/ReactNativeRenderer-dev.js <https://github.com/ptmt/react-native-macos/pull/225/files#diff-9> (13009) - *D* Libraries/Renderer/ReactNativeRenderer-prod.js <https://github.com/ptmt/react-native-macos/pull/225/files#diff-10> (5828) - *A* Libraries/Renderer/oss/ReactFabric-dev.js <https://github.com/ptmt/react-native-macos/pull/225/files#diff-11> (17946) - *A* Libraries/Renderer/oss/ReactFabric-prod.js <https://github.com/ptmt/react-native-macos/pull/225/files#diff-12> (6444) - *A* Libraries/Renderer/oss/ReactFabric-profiling.js <https://github.com/ptmt/react-native-macos/pull/225/files#diff-13> (6639) - *A* Libraries/Renderer/oss/ReactNativeRenderer-dev.js <https://github.com/ptmt/react-native-macos/pull/225/files#diff-14> (18249) - *A* Libraries/Renderer/oss/ReactNativeRenderer-prod.js <https://github.com/ptmt/react-native-macos/pull/225/files#diff-15> (6632) - *A* Libraries/Renderer/oss/ReactNativeRenderer-profiling.js <https://github.com/ptmt/react-native-macos/pull/225/files#diff-16> (6843) - *M* Libraries/Renderer/shims/NativeMethodsMixin.js <https://github.com/ptmt/react-native-macos/pull/225/files#diff-17> (2) - *D* Libraries/Renderer/shims/ReactDebugTool.js <https://github.com/ptmt/react-native-macos/pull/225/files#diff-18> (17) - *A* Libraries/Renderer/shims/ReactFabric.js <https://github.com/ptmt/react-native-macos/pull/225/files#diff-19> (28) - *D* Libraries/Renderer/shims/ReactFeatureFlags.js <https://github.com/ptmt/react-native-macos/pull/225/files#diff-20> (16) - *D* Libraries/Renderer/shims/ReactGlobalSharedState.js <https://github.com/ptmt/react-native-macos/pull/225/files#diff-21> (17) - *M* Libraries/Renderer/shims/ReactNative.js <https://github.com/ptmt/react-native-macos/pull/225/files#diff-22> (3) - *D* Libraries/Renderer/shims/ReactNativeBridgeEventPlugin.js <https://github.com/ptmt/react-native-macos/pull/225/files#diff-23> (17) - *D* Libraries/Renderer/shims/ReactNativeComponentTree.js <https://github.com/ptmt/react-native-macos/pull/225/files#diff-24> (18) - *D* Libraries/Renderer/shims/ReactNativePropRegistry.js <https://github.com/ptmt/react-native-macos/pull/225/files#diff-25> (18) - *M* Libraries/Renderer/shims/ReactNativeTypes.js <https://github.com/ptmt/react-native-macos/pull/225/files#diff-26> (111) - *A* Libraries/Renderer/shims/ReactNativeViewConfigRegistry.js <https://github.com/ptmt/react-native-macos/pull/225/files#diff-27> (112) - *D* Libraries/Renderer/shims/ReactPerf.js <https://github.com/ptmt/react-native-macos/pull/225/files#diff-28> (16) - *M* Libraries/Renderer/shims/ReactTypes.js <https://github.com/ptmt/react-native-macos/pull/225/files#diff-29> (58) - *D* Libraries/Renderer/shims/TouchHistoryMath.js <https://github.com/ptmt/react-native-macos/pull/225/files#diff-30> (17) - *M* Libraries/Renderer/shims/createReactNativeComponentClass.js <https://github.com/ptmt/react-native-macos/pull/225/files#diff-31> (28) - *D* Libraries/Renderer/shims/takeSnapshot.js <https://github.com/ptmt/react-native-macos/pull/225/files#diff-32> (17) - *M* Libraries/StyleSheet/StyleSheet.js <https://github.com/ptmt/react-native-macos/pull/225/files#diff-33> (21) - *M* Libraries/StyleSheet/flattenStyle.js <https://github.com/ptmt/react-native-macos/pull/225/files#diff-34> (21) - *M* RNTester/js/TextExample.macos.js <https://github.com/ptmt/react-native-macos/pull/225/files#diff-35> (12) - *M* RNTester/js/TextInputExample.macos.js <https://github.com/ptmt/react-native-macos/pull/225/files#diff-36> (8) - *M* jest/setup.js <https://github.com/ptmt/react-native-macos/pull/225/files#diff-37> (6) - *M* package.json <https://github.com/ptmt/react-native-macos/pull/225/files#diff-38> (4) Patch Links: -https://github.com/ptmt/react-native-macos/pull/225.patch -https://github.com/ptmt/react-native-macos/pull/225.diff — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#225>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AA9SUy-XunKxwHyFI2YBQVaBnWp9SpX0ks5vH8rHgaJpZM4aXQ4R> . |
This uses the same revision that React Native v0.58.3 is using.
Reviewed By: yisunDifferential Revision: D6692869fbshipit-source-id: 5484070be9995c5294197b0c2766690fd7accefa
Reviewed By: sophiebitsDifferential Revision: D7027263fbshipit-source-id: f4eb3fab402eda337f464e4ebb0771202a9b93f2
Summary:This hasn't been used by React core for a while. It's unclear why it was in the first place.We can move it back next to the Panresponder.facebook/react#12557Reviewed By: sophiebitsDifferential Revision: D7529949fbshipit-source-id: ef9892cfa8d2d6768da216b81befabe02795a245
Reviewed By: sophiebitsDifferential Revision: D7547298fbshipit-source-id: 6ab0c0a9e244a2f68d27307b84285b2c8fff1342
Using
Regarding the error itself, I think I might overlook something related to metro bundler, need some time to investigate. The repo is herehttps://github.com/16ms/videotape |
Thanks again for your work! |
This was referencedMar 14, 2019
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR provides support for the React version used by React Native v0.58.3 (the current version at time of writing). I've done some thorough testing in the RNTester, but it would be great if some other people could test this PR on their own apps and provide feedback.
Note: This PR doesnot include any newnative features, so there are plenty of
react-nativecommits that still need to be ported over. I plan to makeReact hooks work insidereact-native-macosin a future PR, so that's why this PR was created.