Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

cleanup/enhancement: remove unnecessary proto from the sdk and add compdb suport#184

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
wbpcode wants to merge4 commits intoproxy-wasm:main
base:main
Choose a base branch
Loading
fromwbpcode:dev-clean-up

Conversation

@wbpcode
Copy link

@wbpcodewbpcode commentedFeb 27, 2025•
edited
Loading

These protos should be part of specific plugin, but shouldn't be part of the SDK. This change make the SDK more thin and one day we may could make this a single/double file SDK.

Toclose#183

@google-cla
Copy link

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View thisfailed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Signed-off-by: wangbaiping/wbpcode <wbphub@gmail.com>
Signed-off-by: wangbaiping/wbpcode <wbphub@gmail.com>
@wbpcodewbpcode changed the titleremove unnecessary proto from the SDKcleanup/enhancement: remove unnecessary proto from the sdk and add compdb suportFeb 27, 2025
Signed-off-by: wangbaiping(wbpcode) <wbphub@gmail.com>
@wbpcode
Copy link
Author

cc@mpwarres cc@PiotrSikora

@wbpcode
Copy link
Author

Friendly ping@mpwarres

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@PiotrSikoraPiotrSikoraAwaiting requested review from PiotrSikoraPiotrSikora is a code owner

@martijnekenmartijnekenAwaiting requested review from martijnekenmartijneken is a code owner

@mpwarresmpwarresAwaiting requested review from mpwarresmpwarres is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

whyproxy_wasm_intrinsics.proto is necessary for this SDK?

1 participant

@wbpcode
[8]ページ先頭
©2009-2025 Movatter.jp