- Notifications
You must be signed in to change notification settings - Fork85
Generate ES6-style code (classes, exports, imports)#156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Draft
gonzojive wants to merge30 commits intoprotocolbuffers:mainChoose a base branch
base:main
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
…rated code.The introduction of this type changes the signatures of many generator methodsthat need to know how to print a JavaScript expression that refers to a givenproto message or enum.
…rocessors.The import paths for proto imports don't work with our bazel rules, so wepost-process the protobuf-javascript generator's output to rewrite theimports. This is easier if each import has a comment indicating thecorresponding proto file.
Before this, the parent type would be returned. Now, <parent type>.<child type>is returned.
goulashify commentedMay 2, 2023
This is awesome! |
Enable compilation of protos which use the `extend` keyword. A gRPC-web service broke es6 compilation due to importing [`longrunning/operations.proto`](https://github.com/googleapis/googleapis/blob/master/google/longrunning/operations.proto), which uses annotations, which use extensions.Testing of this is being done in `rules_ts_proto` repo: [PR#9](https://github.com/gonzojive/rules_ts_proto/pull/9/files)
rinarakaki commentedJan 19, 2024
Any update? |
The branch works and has been updated with many fixes. We use it in web apps at work. However, last I checked, it will not be accepted upstream because the change is so large. |
perezd commentedAug 3, 2024
Shameless plug, you might be interested in checking out protobuf-es:https://github.com/bufbuild/protobuf-es It fully supports TypeScript and ESM and is completely conformant and compatible with the Protobuf format. |
Fixes compilation using bzlmod and makes bzlmod the default.
stasberkov commentedAug 27, 2024 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Guys, can you make this thing moving forward? I would really like to have ESM module instead of CJS modules. |
In my fork I have been maintaining and improving the ES6 support. I don'tthink the maintainers of the main repo have enough time to review thechange and get it into shape to submit. …On Tue, Aug 27, 2024, 8:23 AM Stanislav Berkov ***@***.***> wrote: Guys, can you make this thing moving forward? I would really like to have ESM module instead of CJS modules. — Reply to this email directly, view it on GitHub <#156 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAAUO5Y4AHQE6IAGDHZTMBDZTSKVTAVCNFSM6AAAAAAST6WIB2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMJSHA3DMOBRGE> . You are receiving this because you authored the thread.Message ID: ***@***.***> |
meteorcloudy pushed a commit to bazelbuild/bazel-central-registry that referenced this pull requestSep 30, 2024
Checked with `python3 tools/bcr_validation.py--check=protobuf_javascript_esm`.The module in question is my fork of the protobuf-javascript repo. Thechanges in the fork are unlikely to be accepted upstream (seeprotocolbuffers/protobuf-javascript#156).
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is a long-standing request for ES6 module generation:#75. This PR mostly adds such support, though it needs to be cleaned up, fixed and tested.
The code generator should still produce the same output for previously supported inputs. The es6 option changes the output style significantly.