- Notifications
You must be signed in to change notification settings - Fork15.9k
bazel: add missing rules_cc loads#23584
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Closed
Closed
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
This is required for use with bazel after this commitbazelbuild/bazel@71ca0edMany files have these already
Contributor
fmeum commentedSep 22, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Could this be included in the next minor release? |
zhangskz approved these changesOct 3, 2025
Member
zhangskz commentedOct 3, 2025
Looks like this will be needed for Bazel 9 support which is released in November so likely won't officially support until at least v34.0. We just cut v33.0-RC1, but I think this seems reasonable to include in v33.0 anyways. |
copybara-servicebot pushed a commit that referenced this pull requestOct 10, 2025
This is required for use with bazel after this commitbazelbuild/bazel@71ca0edMany files have these alreadyCloses#23584COPYBARA_INTEGRATE_REVIEW=#23584 from keith:ks/bazel-add-missing-rules_cc-loads733a0ccFUTURE_COPYBARA_INTEGRATE_REVIEW=#23584 from keith:ks/bazel-add-missing-rules_cc-loads733a0ccPiperOrigin-RevId: 817800800
mkruskal-google pushed a commit that referenced this pull requestOct 13, 2025
This is required for use with bazel after this commitbazelbuild/bazel@71ca0edMany files have these alreadyCloses#23584COPYBARA_INTEGRATE_REVIEW=#23584 from keith:ks/bazel-add-missing-rules_cc-loads733a0ccPiperOrigin-RevId: 817836399
mkruskal-google added a commit that referenced this pull requestOct 13, 2025
bazel: add missing rules_cc loads (#23584)
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is required for use with bazel after this commitbazelbuild/bazel@71ca0ed
Many files have these already