Commite66379f

authored

fix: do not let setProperty change the prototype (#1899)

* fix: do not let setProperty change the prototype* test: add unit test

1 parent56b1e64 commite66379fCopy full SHA for e66379f

File tree

+10

-1

lines changed

+10

-1

lines changed

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -176,7 +176,7 @@ util.decorateEnum = function decorateEnum(object) {`
`176`	`176`	`util.setProperty=functionsetProperty(dst,path,value){`
`177`	`177`	`functionsetProp(dst,path,value){`
`178`	`178`	`varpart=path.shift();`
`179`		`-if(part==="__proto__"){`
	`179`	`+if(part==="__proto__"\|\|part==="prototype"){`
`180`	`180`	`returndst;`
`181`	`181`	`}`
`182`	`182`	`if(path.length>0){`

Lines changed: 9 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -95,6 +95,15 @@ tape.test("util", function(test) {`
`95`	`95`
`96`	`96`	`util.setProperty(o,'prop.subprop',{subsub2:7});`
`97`	`97`	`test.same(o,{prop1:[5,6],prop:{subprop:[{subsub:[5,6]},{subsub2:7}]}},"should convert nested properties to array");`
	`98`	`+`
	`99`	`+util.setProperty({},"__proto__.test","value");`
	`100`	`+test.is({}.test,undefined);`
	`101`	`+`
	`102`	`+util.setProperty({},"prototype.test","value");`
	`103`	`+test.is({}.test,undefined);`
	`104`	`+`
	`105`	`+util.setProperty({},"constructor.prototype.test","value");`
	`106`	`+test.is({}.test,undefined);`
`98`	`107`
`99`	`108`	`test.end();`
`100`	`109`	`});`

Comments

(0)