- Notifications
You must be signed in to change notification settings - Fork759
Preventerase_when_done affecting full screen apps#1663
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Open
joouha wants to merge1 commit intoprompt-toolkit:mainChoose a base branch
base:main
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Member
jonathanslenders commentedSep 2, 2022
I think we should call |
da4335c toa07a7b1CompareSign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If
erase_when_doneandfull_screenare both set toTruefor an application, then the renderer never gets reset. This causes issues such as the cursor does not getting shown if it is hidden when exiting an application.This PR works around this by ignoring
erase_when_donefor full-screen apps.I think
erase_when_doneshould not really apply to full screen apps, as they effectively will always get erased when exiting the alternate screen.I think it's unlikely that anyone depends on the existing behaviour, so hopefully it wouldn't break anything for anyone - let me know what you think.